Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script: update REVIEWERS #21823

Merged
merged 1 commit into from
May 3, 2021
Merged

script: update REVIEWERS #21823

merged 1 commit into from
May 3, 2021

Conversation

jonatack
Copy link
Contributor

@jonatack jonatack commented May 1, 2021

Meta: git show a06eb03 indicates the commit was first made one year ago and the PR was merged in September 2020.

It might be time for an update, if automated review requests via DrahtBot are operational.

"Regular contributors are free to add their names to specific directories or files provided that they are willing to provide a review."

Perhaps we can compile and squash suggested updates here, per that guideline.

@jonatack
Copy link
Contributor Author

jonatack commented May 1, 2021

Tagging @adamjonas added as author.

@fanquake fanquake added the Docs label May 2, 2021
@laanwj
Copy link
Member

laanwj commented May 2, 2021 •
edited
Loading

ACK 5f4449b
Also adds @hebasto which is good.
(but might be good to hold off immediate merging, as said in the OP, to aggregate more desired changes)

@Sjors
Copy link
Member

Sjors commented May 3, 2021

Feel free to add below Descriptors:

# External signer
*external_signer*                           @sjors
docs/external-signer.md                     @sjors
*signer.py                                  @sjors

And somewhere else:

# Backwards compatibility tests
test/functional/feature_backwards_compatibility.py @sjors
test/functional/mempool_compatibility.py           @sjors
test/get_previous_releases.py                      @sjors
test/functional/wallet_upgradewallet.py            @sjors @achow101

(maybe use *_compatibility.py for the first two lines)

@maflcko
Copy link
Member

maflcko commented May 3, 2021

It wasn't clear to me whether people liked what DrahtBot does, so I am not running it 24/7. Since people are still happily adding themselves to the list, I presume I should run it more often?

@Sjors
Copy link
Member

Sjors commented May 3, 2021

I don't mind getting a notification, though it might be annoying for copyright year changes and stuff like that.

@jonatack
Copy link
Contributor Author

jonatack commented May 3, 2021

@Sjors nice; updated.

@maflcko
Copy link
Member

maflcko commented May 3, 2021

annoying for copyright year changes

Sure, but this change should only happen once a year per file. Though, it is currently unclear if the listed reviewers want to be notified about refactoring changes of the listed files.

@jonatack
Copy link
Contributor Author

jonatack commented May 3, 2021 •
edited
Loading

Maybe sending review notifications a couple of times a week would be a good frequency, as a suggestion.

@jonatack jonatack mentioned this pull request May 3, 2021
Closed
@jonatack jonatack closed this May 3, 2021
@jonatack
Copy link
Contributor Author

jonatack commented May 3, 2021

Re-opening, sorry, crossed signals.

@jonatack jonatack reopened this May 3, 2021
@practicalswift
Copy link
Contributor

ACK 48bd9eb: patch looks correct :)

hebasto
hebasto approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 48bd9eb, I have reviewed the code and it looks OK, I agree it can be merged.

@adamjonas
Copy link
Member

Glad to hear people still want this.

ACK 48bd9eb. I ran through the new files added with *s using git ls-files.

@maflcko maflcko merged commit 3692097 into bitcoin:master May 3, 2021
@jonatack jonatack deleted the update-REVIEWERS branch May 3, 2021 17:18
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@PastaPastaPasta
Merge bitcoin#21823: script: update REVIEWERS
5c0dc92 
48bd9eb script: update REVIEWERS (Adam Jonas)

Pull request description:

  Meta: `git show a06eb03` indicates the commit was first made one year ago and the PR was merged in September 2020.

  It might be time for an update, if automated review requests via DrahtBot are operational.

  "Regular contributors are free to add their names to specific directories or files provided that they are willing to provide a review."

  Perhaps we can compile and squash suggested updates here, per that guideline.

ACKs for top commit:
  practicalswift:
    ACK 48bd9eb: patch looks correct :)
  adamjonas:
    ACK 48bd9eb. I ran through the new files added with `*`s using `git ls-files`.
  hebasto:
    ACK 48bd9eb, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: 770fd60d78bd64100814c72211e4bd97718c87a55a4c91e136fababa0149d12cdc1b3e89462dee3a55e5f51d3263420cc6d856868469eb9a72ff8c930859c54f
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@PastaPastaPasta
Merge bitcoin#21823: script: update REVIEWERS
3927795 
48bd9eb script: update REVIEWERS (Adam Jonas)

Pull request description:

  Meta: `git show a06eb03` indicates the commit was first made one year ago and the PR was merged in September 2020.

  It might be time for an update, if automated review requests via DrahtBot are operational.

  "Regular contributors are free to add their names to specific directories or files provided that they are willing to provide a review."

  Perhaps we can compile and squash suggested updates here, per that guideline.

ACKs for top commit:
  practicalswift:
    ACK 48bd9eb: patch looks correct :)
  adamjonas:
    ACK 48bd9eb. I ran through the new files added with `*`s using `git ls-files`.
  hebasto:
    ACK 48bd9eb, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: 770fd60d78bd64100814c72211e4bd97718c87a55a4c91e136fababa0149d12cdc1b3e89462dee3a55e5f51d3263420cc6d856868469eb9a72ff8c930859c54f
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@PastaPastaPasta
Merge bitcoin#21823: script: update REVIEWERS
9580f65 
48bd9eb script: update REVIEWERS (Adam Jonas)

Pull request description:

  Meta: `git show a06eb03` indicates the commit was first made one year ago and the PR was merged in September 2020.

  It might be time for an update, if automated review requests via DrahtBot are operational.

  "Regular contributors are free to add their names to specific directories or files provided that they are willing to provide a review."

  Perhaps we can compile and squash suggested updates here, per that guideline.

ACKs for top commit:
  practicalswift:
    ACK 48bd9eb: patch looks correct :)
  adamjonas:
    ACK 48bd9eb. I ran through the new files added with `*`s using `git ls-files`.
  hebasto:
    ACK 48bd9eb, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: 770fd60d78bd64100814c72211e4bd97718c87a55a4c91e136fababa0149d12cdc1b3e89462dee3a55e5f51d3263420cc6d856868469eb9a72ff8c930859c54f
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin#21823: script: update REVIEWERS
2efbfb6 
48bd9eb script: update REVIEWERS (Adam Jonas)

Pull request description:

  Meta: `git show a06eb03` indicates the commit was first made one year ago and the PR was merged in September 2020.

  It might be time for an update, if automated review requests via DrahtBot are operational.

  "Regular contributors are free to add their names to specific directories or files provided that they are willing to provide a review."

  Perhaps we can compile and squash suggested updates here, per that guideline.

ACKs for top commit:
  practicalswift:
    ACK 48bd9eb: patch looks correct :)
  adamjonas:
    ACK 48bd9eb. I ran through the new files added with `*`s using `git ls-files`.
  hebasto:
    ACK 48bd9eb, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: 770fd60d78bd64100814c72211e4bd97718c87a55a4c91e136fababa0149d12cdc1b3e89462dee3a55e5f51d3263420cc6d856868469eb9a72ff8c930859c54f
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin#21823: script: update REVIEWERS
bcc76f1 
48bd9eb script: update REVIEWERS (Adam Jonas)

Pull request description:

  Meta: `git show a06eb03` indicates the commit was first made one year ago and the PR was merged in September 2020.

  It might be time for an update, if automated review requests via DrahtBot are operational.

  "Regular contributors are free to add their names to specific directories or files provided that they are willing to provide a review."

  Perhaps we can compile and squash suggested updates here, per that guideline.

ACKs for top commit:
  practicalswift:
    ACK 48bd9eb: patch looks correct :)
  adamjonas:
    ACK 48bd9eb. I ran through the new files added with `*`s using `git ls-files`.
  hebasto:
    ACK 48bd9eb, I have reviewed the code and it looks OK, I agree it can be merged.

Tree-SHA512: 770fd60d78bd64100814c72211e4bd97718c87a55a4c91e136fababa0149d12cdc1b3e89462dee3a55e5f51d3263420cc6d856868469eb9a72ff8c930859c54f
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@apoelstra
Merge 3692097 into merged_master (Bitcoin PR bitcoin/bitcoin#21823)
bfdf82b
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hebasto hebasto hebasto approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jonatack @laanwj @Sjors @maflcko @practicalswift @adamjonas @hebasto @fanquake