Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: Limit max insertions in timedata fuzz test #21909

Merged
merged 1 commit into from
May 11, 2021

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented May 11, 2021

It is debatable whether a size of the median filter other than 200 (the only size used in production) should be fuzzed. For now add a minimal patch to cap the max insertions. Otherwise the complexity is N^2 log(N), where N is the size of the fuzz input.

Hopefully fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34167

@practicalswift
Copy link
Contributor

cr ACK fa95555: patch looks correct

@practicalswift
Copy link
Contributor

@MarcoFalke Don't forget to make the issues public before posting links to the OSS-Fuzz bug tracker, otherwise reviewers won't be able to view them :)

@maflcko maflcko merged commit 88dc09d into bitcoin:master May 11, 2021
@maflcko maflcko deleted the 2105-fuzzMedian branch May 11, 2021 18:47
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 11, 2021
fa95555 fuzz: Limit max insertions in timedata fuzz test (MarcoFalke)

Pull request description:

  It is debatable whether a size of the median filter other than `200` (the only size used in production) should be fuzzed. For now add a minimal patch to cap the max insertions. Otherwise the complexity is N^2 log(N), where N is the size of the fuzz input.

  Hopefully fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34167

ACKs for top commit:
  practicalswift:
    cr ACK fa95555: patch looks correct

Tree-SHA512: be7737e9f4c906053e355641de84dde31fed37ed6be4c5e92e602ca7675dffdaf06b7063b9235ef541b05d3d5fd689c99479317473bb15cb5271b8baabffd0f2
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 17, 2022
fa95555 fuzz: Limit max insertions in timedata fuzz test (MarcoFalke)

Pull request description:

  It is debatable whether a size of the median filter other than `200` (the only size used in production) should be fuzzed. For now add a minimal patch to cap the max insertions. Otherwise the complexity is N^2 log(N), where N is the size of the fuzz input.

  Hopefully fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34167

ACKs for top commit:
  practicalswift:
    cr ACK fa95555: patch looks correct

Tree-SHA512: be7737e9f4c906053e355641de84dde31fed37ed6be4c5e92e602ca7675dffdaf06b7063b9235ef541b05d3d5fd689c99479317473bb15cb5271b8baabffd0f2
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants