Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.21] depends: update Qt 5.9 source url #21932

Merged
merged 1 commit into from May 13, 2021
Merged

[0.21] depends: update Qt 5.9 source url #21932

merged 1 commit into from May 13, 2021

Conversation

kwvg
Copy link
Contributor

@kwvg kwvg commented May 12, 2021

Expected Behavior

Running make in the depends directory should result in the successful building of host platform dependencies

Actual Behavior

make terminates as qt.mk points to (now) outdated URL path for Qt 5.9 sources, returning error 404

Remedy

Update qt.mk to point to updated source location as Qt has relocated them

@hebasto
Copy link
Member

hebasto commented May 12, 2021

Since #21376 we are using Qt 5.12.10.

@kwvg
Copy link
Contributor Author

kwvg commented May 12, 2021

Having depends of still officially supported versions point to dead URLs doesn't seem the most advisable, a lot of projects rely on those supported versions being functional in a complete sense

@maflcko maflcko changed the title depends: update Qt 5.9 source url [0.21] depends: update Qt 5.9 source url May 12, 2021
@hebasto
Copy link
Member

hebasto commented May 12, 2021

Having depends of still officially supported versions point to dead URLs doesn't seem the most advisable, a lot of projects rely on those supported versions being functional in a complete sense

Ah, this change into 0.21 branch.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK deff4e7, I have verified the new link, and checked that old one is unavailable:

curl: (22) The requested URL returned error: 404 Not Found

@hebasto
Copy link
Member

hebasto commented May 12, 2021

make terminates as qt.mk points to (now) outdated URL path for Qt 5.9 sources, returning error 404

Btw, make should use https://bitcoincore.org/depends-sources in such cases.

@RandyMcMillan
Copy link
Contributor

RandyMcMillan commented May 12, 2021

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK deff4e7

on branch 0.21, performing a depends build, fetching from the current URL will fail and we default to the bitcoincore.org backup:

Fetching qtbase-opensource-src-5.9.8.tar.xz from https://download.qt.io/official_releases/qt/5.9/5.9.8/submodules
. . . 
curl: (22) The requested URL returned error: 404 Not Found
Fetching qtbase-opensource-src-5.9.8.tar.xz from https://bitcoincore.org/depends-sources

With this PR cherry-picked on top of the 0.21 branch, we can successfully download qt 5.9.8 and not have to rely on the backup:

Fetching qtbase-opensource-src-5.9.8.tar.xz from https://download.qt.io/archive/qt/5.9/5.9.8/submodules```

random-zebra added a commit to PIVX-Project/PIVX that referenced this pull request May 13, 2021
fc6d7b9 depends: update Qt 5.9 source url (Kittywhiskers Van Gogh)

Pull request description:

  Straightforward, updating archived qt 5.9 url. bitcoin#21932

ACKs for top commit:
  Fuzzbawls:
    utACK fc6d7b9
  random-zebra:
    utACK fc6d7b9 and merging...

Tree-SHA512: 5330fb6af9f7d71807e60ce394ad80ce824a2247b67351df06134ea0627b1a07c6d6c411546f5b0d9294a10fa26e9075270bf5bb4afaefd76df393201313ad57
@laanwj laanwj merged commit 58c0742 into bitcoin:0.21 May 13, 2021
@kwvg kwvg deleted the patch-1 branch May 15, 2021 05:20
Copy link

@Tiz-Max Tiz-Max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@bitcoin bitcoin locked and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants