New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.21] depends: update Qt 5.9 source url #21932
Conversation
Since #21376 we are using Qt 5.12.10. |
Having depends of still officially supported versions point to dead URLs doesn't seem the most advisable, a lot of projects rely on those supported versions being functional in a complete sense |
Ah, this change into 0.21 branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK deff4e7, I have verified the new link, and checked that old one is unavailable:
curl: (22) The requested URL returned error: 404 Not Found
Btw, |
tACK deff4e7 Should LTS be bumped to 5.9.9? 0c6054f#diff-0d7e256978e78897b774581dad22102138ce4ba46aa07faaef1ae6fc6178aad4R2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK deff4e7
on branch 0.21
, performing a depends build, fetching from the current URL will fail and we default to the bitcoincore.org
backup:
Fetching qtbase-opensource-src-5.9.8.tar.xz from https://download.qt.io/official_releases/qt/5.9/5.9.8/submodules
. . .
curl: (22) The requested URL returned error: 404 Not Found
Fetching qtbase-opensource-src-5.9.8.tar.xz from https://bitcoincore.org/depends-sources
With this PR cherry-picked on top of the 0.21
branch, we can successfully download qt 5.9.8
and not have to rely on the backup:
Fetching qtbase-opensource-src-5.9.8.tar.xz from https://download.qt.io/archive/qt/5.9/5.9.8/submodules```
fc6d7b9 depends: update Qt 5.9 source url (Kittywhiskers Van Gogh) Pull request description: Straightforward, updating archived qt 5.9 url. bitcoin#21932 ACKs for top commit: Fuzzbawls: utACK fc6d7b9 random-zebra: utACK fc6d7b9 and merging... Tree-SHA512: 5330fb6af9f7d71807e60ce394ad80ce824a2247b67351df06134ea0627b1a07c6d6c411546f5b0d9294a10fa26e9075270bf5bb4afaefd76df393201313ad57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Expected Behavior
Running
make
in the depends directory should result in the successful building of host platform dependenciesActual Behavior
make
terminates asqt.mk
points to (now) outdated URL path for Qt 5.9 sources, returning error 404Remedy
Update
qt.mk
to point to updated source location as Qt has relocated them