Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: Speed up transaction fuzz target #22004

Merged
merged 1 commit into from
May 21, 2021
Merged

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented May 20, 2021

hashBlock and include_addresses are orthogonal, so no need to do an exhaustive "search".

Might fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34491

@maflcko
Copy link
Member Author

maflcko commented May 20, 2021

Screenshot from 2021-05-20 17-26-33

@DrahtBot DrahtBot added the Tests label May 20, 2021
@practicalswift
Copy link
Contributor

practicalswift commented May 20, 2021

cr ACK bbbb518: patch looks correct, and TxToUniv surprisingly wide in the transaction_fuzz_target flame graph! Putting it on a diet makes sense.

@maflcko maflcko merged commit eb4df9a into bitcoin:master May 21, 2021
@maflcko maflcko deleted the 2105-fuzzTx branch May 21, 2021 09:26
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 21, 2021
bbbb518 fuzz: Speed up transaction fuzz target (MarcoFalke)

Pull request description:

  `hashBlock` and `include_addresses` are orthogonal, so no need to do an exhaustive "search".

  Might fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34491

ACKs for top commit:
  practicalswift:
    cr ACK bbbb518: patch looks correct, and `TxToUniv` surprisingly wide in the `transaction_fuzz_target` flame graph! Putting it on a diet makes sense.

Tree-SHA512: 1e7c30c7fecf96364a9a1597c0a22139389fdeb67db59f3c2c6fc088196e3332877b2865991a957980d542f99a2f48cc066dd7cc16c695a5113190fe06205089
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants