fuzz: don't try and use fopencookie() when building for Android #22069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building for Android, _GNU_SOURCE will be defined, but it doesn't actually have the fopencookie() function, or define the cookie_io_functions_t type. For now just skip trying to use it if we are building for Android. Should fix bitcoin#22062.
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 27, 2021
…ing for Android 1be6267 fuzz: don't try and use fopencookie when building for Android (fanquake) Pull request description: When building for Android, `_GNU_SOURCE` will be defined: ```bash /home/ubuntu/android-sdk/ndk/22.1.7171670/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android30-clang++ -dM -E -x c++ - < /dev/null #define _GNU_SOURCE 1 #define _LP64 1 #define __AARCH64EL__ 1 #define __AARCH64_CMODEL_SMALL__ 1 #define __ANDROID_API__ 30 #define __ANDROID__ 1 #define __ARM_64BIT_STATE 1 ..... ``` but it doesn't have the [`fopencookie()` function](https://www.gnu.org/software/libc/manual/html_node/Streams-and-Cookies.html), or define the `cookie_io_functions_t` type, which results in compile failures: ```bash In file included from test/fuzz/addition_overflow.cpp:7: ./test/fuzz/util.h:388:15: error: unknown type name 'cookie_io_functions_t' const cookie_io_functions_t io_hooks = { ^ 15 warnings and 1 error generated. ``` Just skip trying to use it if we are building for Android. Should fix bitcoin#22062. ACKs for top commit: practicalswift: cr ACK 1be6267 Tree-SHA512: d62f63d0624af04b76c7e07b0332c71eca2bf9cd9e096a60aea9e212b7bbc1548e9fa9a76d065ec719bb345fe8726619c3bd2d0631f54d877c82972b7b289321
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building for Android,
_GNU_SOURCEwill be defined:but it doesn't have the
fopencookie()function, or define thecookie_io_functions_ttype, which results in compile failures:Just skip trying to use it if we are building for Android. Should fix #22062.