-
Notifications
You must be signed in to change notification settings - Fork 36k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bench, doc: benchmarking updates and fixups #22292
Conversation
Concept ACK Thanks for improving this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK, is obviously an improvement to the docs
3c48b78
to
3f408dd
Compare
- remove unneeded strprintf - consistent punctuation (no EOL periods) - sort helps by order they are printed (alphabetical order)
3f408dd
to
d8513fe
Compare
Concept ACK, nice benchmark doc improvements! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK d8513fe 🚤
Reviewed the documentation changes, ran ./src/bench/bench_bitcoin -filter="AddrManAdd|AddrManGetAddr|Base58CheckEncode|Base58Decode"
to verify that the example output format in the last commit matches.
ACK d8513fe Reviewed documentation and it's definitely an improvement to what was already there, also ran Note - running |
This change is required since bitcoin/bitcoin#22292 was merged.
75b84b4 Update patches/stripbuildinfo.patch (Hennadii Stepanov) Pull request description: This change is required since bitcoin/bitcoin#22292 was merged. ACKs for top commit: fanquake: Tested ACK 75b84b4 Tree-SHA512: d318a802c8c27574c04b7bec339ca41e7dd8648e34a5c9e57ec6a3234a92606dc86df9e09e280a0b3bb0e537650b14f3c69a80c36b7601b5e07766a19e930a9f
Fixups and updates I noticed while writing benchmarks for #22284.