build: Avoid qt-specific @GLIBC_2.28 symbols for compatibility #22321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jun 23, 2021
|
Closing in favor of #22365. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #22244, new symbols were introduced in
bitcoin-qtduring the current release cycle, particularly:statx@GLIBC_2.28renameat2@GLIBC_2.28This PR gets rid of them.
Removing of
statxis pretty hacky because it is integrated into Qt code tightly, and just passing-no-feature-statxdon't work.See:
Closes #22280.
Note for reviewers. While testing please post kernel and glib versions of systems you run tested binaries on.
It would be nice to test systems with pretty old ones (e.g., pre-4.11 kernel).