Ignore banlist.dat #22570
Merged
Ignore banlist.dat #22570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanquake
reviewed
Jul 29, 2021
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jul 29, 2021
maflcko
force-pushed
the
2107-noSerSubnet
branch
from
fa08473
to
fa718ea
Compare
|
Concept ACK |
vasild
reviewed
Jul 29, 2021
Yes, the pull request is to the |
maflcko
force-pushed
the
2107-noSerSubnet
branch
2 times, most recently
from
fa81dae
to
fac51e9
Compare
vasild
approved these changes
Jul 29, 2021
Zero-1729
approved these changes
Jul 29, 2021
|
Further cleanup is possible: bitcoin/src/test/fuzz/banman.cpp Line 55 in 787296e bitcoin/src/test/fuzz/banman.cpp Line 117 in 787296e |
added 3 commits
July 30, 2021 11:21
This also allows to remove the "dirty" argument, which can now be deduced from the return value of Read().
Leaving the incorrect indentation would be frustrating because: * Some editor may fix up the whitespace when editing a file, so before commiting the whitespace changes need to be undone. * It makes it harder to use clang-format-diff on a change. Can be trivially reviewed with --word-diff-regex=. --ignore-all-space
maflcko
force-pushed
the
2107-noSerSubnet
branch
from
fac51e9
to
fa1eddb
Compare
|
re-ACK fa1eddb |
vasild
approved these changes
Jul 30, 2021
Zero-1729
approved these changes
Jul 31, 2021
|
Not a big fan of the huge whitespace change in the last commit, but otherwise |
|
Release notes for 23.0 added in #22603 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 4, 2021
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Aug 4, 2021
….dat) fa2c868 doc: Add release notes for 22570 (ignore banlist.dat) (MarcoFalke) Pull request description: Follow-up to bitcoin#22570 ACKs for top commit: tryphe: ACK fa2c868 vasild: ACK fa2c868 Zero-1729: ACK fa2c868 Tree-SHA512: 58eef340b6211bcdecf3826ac145afd476c397f110daa6783521c0c1e1be1ffbd2d24ad20c77921abbe5cdb8e644d3cd64e14e2819746cf0e5123fb7cc445d63
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 4, 2021
….dat) fa2c868 doc: Add release notes for 22570 (ignore banlist.dat) (MarcoFalke) Pull request description: Follow-up to bitcoin#22570 ACKs for top commit: tryphe: ACK fa2c868 vasild: ACK fa2c868 Zero-1729: ACK fa2c868 Tree-SHA512: 58eef340b6211bcdecf3826ac145afd476c397f110daa6783521c0c1e1be1ffbd2d24ad20c77921abbe5cdb8e644d3cd64e14e2819746cf0e5123fb7cc445d63
|
Looks like we can re-enable the disabled assert again due to the removal of the code here: #22657 |
maflcko
pushed a commit
that referenced
this pull request
Sep 6, 2021
6919c82 MOVEONLY: Expose BanMapToJson / BanMapFromJson (Russell Yanofsky) Pull request description: This PR is part of the [process separation project](https://github.com/bitcoin/bitcoin/projects/10). --- CSubNet serialization code that was removed in #22570 fa4e6af was needed by multiprocess code to share ban map between gui and node processes. Rather than adding it back, use suggestion from MarcoFalke #10102 (comment) to use JSON serialization. This requires making BanMapToJson / BanMapFromJson functions public. ACKs for top commit: promag: reACK 6919c82. Tree-SHA512: ce909a61b7869d16cf2e9f91b643dd9d2604efc5777703d3b77a4c40cb0ccdd20396ba87b1ec85aade142e12ff9ea4c95c7155840354873579565471779f5a33
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to read
banlist.datshould be removed eventually. The major release (22.x) can be used to translate abanlist.datinto abanlist.json. Thus, it is now possible to remove the reading code.