New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Use test framework utils where possible #23127
tests: Use test framework utils where possible #23127
Conversation
Thanks for contributing and helping out @vincenzopalazzo! |
d1c6861
to
ab7b997
Compare
Concept ACK |
Will it be created new PRs to update other tests or should we concentrate all the changes here? |
The plan is to divide the work into small chunks to make the price of PR review easy and fast. |
Cool, thanks! |
I just created #23135 to help on it |
Thanks, the important think it that we don't make the double work :-) |
97ba20f
to
580754c
Compare
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
580754c
to
0ff961c
Compare
62112a2
to
80c593f
Compare
Concept ACK I think generally splitting across multiple pull requests works best for the monster sub-projects (AssumeUTXO, deglobalizing ChainstateManager, Process Separation etc). In this case splitting across multiple commits within the same PR would probably have been sufficient to make it easily reviewable but not a big deal and if it encourages multiple contributors to self-organize around completing it then that's great. |
a83d95b
to
6fbb7e1
Compare
Thanks @michaelfolkson,
It sounds great to me, I will go with this solution. Thansk! |
ac5796a
to
5352392
Compare
5352392
to
fab2ba3
Compare
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> # Title: Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
5247985
to
62ed9ff
Compare
@vincenzopalazzo Given #25732, did you want to leave this one open as well, or close for now? |
better close this and hope that someone will finish the job :) |
This PR removes when it is possible the native python assert, and use the test utils function, like
assert_equal
,assert_greater_than
,assert_greater_than_or_equal
.Update
In addition, this PR includes a new operator
assert_not_equal
, which IMO it is useful to test other conditions and add the error message as a parameter of the function to give more flexibility.Fixes #23119
Edit laanwj: removed HTML comment from post