doc: Revert "Remove outdated comments" and place comment correctly #23130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ee7891a, and moves the comments into the right place.
|
cc @fanquake |
|
cr ACK 8ff3743 |
|
Sorry for merging it so quickly it seemed obvious to me. |
laanwj
changed the title
|
ACK 8ff3743 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 30, 2021
… comment correctly 8ff3743 Revert "doc: Remove outdated comments" (Hennadii Stepanov) Pull request description: Unfortunately, in bitcoin#23094 the assumption that bitcoin#14336 makes comments outdated is wrong. As pointed in bitcoin#23094 (comment), the bitcoin#14336 just moved the relevant code a few lines down. This PR reverts commit ee7891a, and moves the comments into the right place. I apologize about that. ACKs for top commit: MarcoFalke: cr ACK 8ff3743 laanwj: ACK 8ff3743 Tree-SHA512: 84aca627bb5b49c06fc172778f9b9407482c5a873ccbc3dc40167e6a8ad0bc60475d6a469c843b7b42712e35cf3fc2d3518923e791d5e0c59628e042acc72747
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, in #23094 the assumption that #14336 makes comments outdated is wrong. As pointed in #23094 (comment), the #14336 just moved the relevant code a few lines down.
This PR reverts commit ee7891a, and moves the comments into the right place.
I apologize about that.