build: add python3.10 alias to AC_PATH_PROGS call in configure #23182
Conversation
Python 3.10 is now relased, and has been available as a beta/rc in distros for a little while already.
|
Might as well add 3.11 to buy us 6 more months of having not to touch this again? |
|
cr ACK ef15c57 |
I sometimes wonder if we can do something smarter than hardcoding all the versions… (also why this order? why do we prefer lower versions) That said, I'm good on kicking this particular can down the road one more time, doesn't seem something worth spending a lot of time on. |
|
This patch will only makes a difference if
My guess is that it makes it easier for devs to find incompatibilities with the minimum supported version. |
Good point. |
There was a problem hiding this comment.
ACK ef15c57, I have reviewed the code and it looks OK, I agree it can be merged.
UPDATE: #23182 (comment)
| @@ -107,7 +107,7 @@ AC_PATH_TOOL(GCOV, gcov) | |||
| AC_PATH_TOOL(LLVM_COV, llvm-cov) | |||
| AC_PATH_PROG(LCOV, lcov) | |||
| dnl Python 3.6 is specified in .python-version and should be used if available, see doc/dependencies.md | |||
| AC_PATH_PROGS([PYTHON], [python3.6 python3.7 python3.8 python3.9 python3 python]) | |||
| AC_PATH_PROGS([PYTHON], [python3.6 python3.7 python3.8 python3.9, python3.10, python3 python]) | |||
There was a problem hiding this comment.
Commas actually break checking, and they must be dropped.
AC_PATH_PROGS won't find python3.9 and python3.10 executables.
There was a problem hiding this comment.
@fanquake Are you testing the review process? 👀
There was a problem hiding this comment.
👀. Will be addressed in a follow up shortly.
There was a problem hiding this comment.
Included the fix here: #23270, lmk if you'd like to take a different approach.
…l in configure ef15c57 build: add python3.10 alias to AC_PATH_PROGS call in configure (fanquake) Pull request description: Python 3.10 is [now released](https://pythoninsider.blogspot.com/2021/10/python-3100-is-available.html), and has been available as a beta/rc in distros for a little while already. ACKs for top commit: MarcoFalke: cr ACK ef15c57 laanwj: Code review ACK ef15c57 hebasto: ACK ef15c57, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 4d503d43dfbe210ac6180c63276d4ebe1aa39b0ada2a36c1292634f86603c385179b3034759441401a9ee5022f7687ccd5f3432be5c4e63f2eba7ddb76f5cbb9
We can't possibly know in advance if newer versions will break our scripts? |
23182 was broken. Fix up the changes, and add python3.11 as suggested.
|
Ultimately fixed in #23317. |
a78137e build: fix python detection post #23182 (fanquake) Pull request description: #23182 was broken. Fixup the changes, and add python3.11 as suggested. Was going to include this in other changes, but no point leaving this broken any longer. ACKs for top commit: MarcoFalke: cr ACK a78137e hebasto: ACK a78137e, tested on Ubuntu Impish 21.10 running `./configure`: Tree-SHA512: f77cbea76710617eaea85787351a707cc2dcfb7e5962fc6d63ea11e737ee96cb2a496a2a4bb5a147b37ba87b0428977d9295ea053e25417ea13f43137c959919
23182 was broken. Fix up the changes, and add python3.11 as suggested.
Python 3.10 is now relased, and has been available as a beta/rc in distros for a little while already. Github-Pull: bitcoin#23182 Rebased-From: ef15c57
23182 was broken. Fix up the changes, and add python3.11 as suggested. Github-Pull: bitcoin#23317 Rebased-From: a78137e
Python 3.10 is now released, and has been available as a beta/rc in distros for a little while already.