doc: fix XOnlyPubKey::IsFullyValid comment reference
#23400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipa
reviewed
Nov 8, 2021
The method name `CreatePayToContract` doesn't exist, very likely it was a (local) working title that was renamed to `CreateTapTweak` later. Also mention `CheckTapTweak`.
theStack
force-pushed
the
202110-doc-fix_xonlypubkey_isvalid_comment
branch
from
1836a9b
to
037c9ee
Compare
|
ACK 037c9ee This is the only reference to |
|
ACK 037c9ee |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 10, 2021
…erence 037c9ee fix `XOnlyPubKey::IsFullyValid` comment reference (Sebastian Falbesoner) Pull request description: The method name `CreatePayToContract` doesn't exist, very likely it was a (local) working title that was renamed to `CreateTapTweak` later. ACKs for top commit: michaelfolkson: ACK 037c9ee sipa: ACK 037c9ee Tree-SHA512: ab2b6ca93b66aba83c725b62f39e9f9316f3bea6f75ef35f66a2ac18b22a0a69ff2069cadab0365b28b0af2d30ad5ee3d3022194ac2024a1cdbb81d106fca0bb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method name
CreatePayToContractdoesn't exist, very likely it was a (local) working title that was renamed toCreateTapTweaklater.