Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet: Avoid underpaying transaction fees when signing taproot spends #23502

Closed
wants to merge 3 commits into from
Closed

wallet: Avoid underpaying transaction fees when signing taproot spends #23502

wants to merge 3 commits into from
+54 −14

Commits on Nov 4, 2022

  1. sign: Include sighash byte for Schnorr sigs with DUMMY_MAX_SIG_CREATOR

    @achow101
    achow101 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    0b33bbe View commit details
    Browse the repository at this point in the history

  2. Add UseLargest function to BaseSignatureCreator 

    Sometimes we need to know whether we should be choosing the largest
stack size for worse case size estimation. BaseSignatureCreator can
report that to us as we only need to do this when using
DummySignatureCreator.
    @achow101
    achow101 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    58a988d View commit details
    Browse the repository at this point in the history

  3. Use largest stack size when estimating size 

    When estimating the size of a taproot witness (i.e.
DummySignatureCreator is being used), use the largest stack size rather
than the smallest. This avoids underpaying fees.

Also updates the tests to make sure that Taproot spends do not
underestimate the fee
    @achow101
    achow101 committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    5345b80 View commit details
    Browse the repository at this point in the history