Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GetSpendHeight #23630

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Remove GetSpendHeight #23630

merged 1 commit into from
Dec 3, 2021

Commits on Dec 2, 2021

  1. Remove GetSpendHeight 

    It is unclear what the goal of the helper is, as the caller already
knows the spend height before calling the helper.

Also, in case the coins view is corrupted, LookupBlockIndex will return
nullptr. Dereferencing a nullptr is UB.

Fix both issues by removing it. Also, add a sanity check, which aborts
if the coins view is corrupted.
    MarcoFalke committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    fa3942f View commit details
    Browse the repository at this point in the history