util: Add SaturatingAdd helper #24224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK. This seems useful, hopefully C++ will have built-ins for explicitly saturating/wrapping/checked arithmetic like rust some day. But until then… |
I wasn't aware that rust has those built-in. Mind sharing a link to the docs? |
|
Oh, I see. By default rust will panic, but there are https://doc.rust-lang.org/std/num/index.html: |
klementtan
approved these changes
Feb 12, 2022
| @@ -28,4 +28,22 @@ template <class T> | |||
| return i + j; | |||
| } | |||
|
|
|||
| template <class T> | |||
| [[nodiscard]] T SaturatingAdd(const T i, const T j) noexcept | |||
There was a problem hiding this comment.
Out of curiosity, any reason you didn't constexpr this function?
There was a problem hiding this comment.
Outside of unit tests I don't think this will ever be called in a context that would be constexpr.
vasild
approved these changes
Feb 21, 2022
|
Added a test. Should be trivial to re-ACK with |
vasild
approved these changes
Feb 21, 2022
|
reACK faa7d8a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems good to have this in the repo, as it might be needed to write cleaner code. For example: