refactor: base58.cpp - preemptively remove deprecated += #24379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to write a PR description. There's also really no need for this to be a scripted diff or two separate commits. |
REF: PR bitcoin#24372 REF: https://eel.is/c++draft/depr.volatile.type#example-2 carry += str += are flagged as deprecated.
RandyMcMillan
force-pushed
the
1645177905-scripted-diff-base58
branch
from
8260de7
to
786a5e6
Compare
RandyMcMillan
changed the title
mzumsande
reviewed
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REF: PR #24372
REF: https://eel.is/c++draft/depr.volatile.type#example-2
carry +=
str +=
are flagged as deprecated.