Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: remove no-longer used exceptions from lint-format-strings.py #24419

Merged
merged 1 commit into from Feb 23, 2022
Merged

lint: remove no-longer used exceptions from lint-format-strings.py #24419

merged 1 commit into from Feb 23, 2022

Conversation

fanquake
Copy link
Member

No description provided.

@hebasto
Copy link
Member

hebasto commented Feb 22, 2022

Concept ACK.

@laanwj
Copy link
Member

laanwj commented Feb 22, 2022

ACK 5b8f248 if it passes CI

hebasto
hebasto approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5b8f248, I've verified that all of the remained false positive cases are valid.

@maflcko maflcko merged commit f062abe into bitcoin:master Feb 23, 2022
@fanquake fanquake deleted the remove_nonexistent_lint_strings branch February 23, 2022 09:13
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Feb 23, 2022
Merge bitcoin#24419: lint: remove no-longer used exceptions from lint…
9559fab 
…-format…
@bitcoin bitcoin locked and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hebasto hebasto hebasto approved these changes

Assignees
No one assigned
Labels
Scripts and tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fanquake @hebasto @laanwj @maflcko