Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add more info to dependencies.md #24586

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Conversation

prusnak
Copy link
Contributor

@prusnak prusnak commented Mar 16, 2022

Follow-up to #23565

I added more info to dependencies.md - especially links to depends/packages/*.mk files and link to PRs where used versions were bumped.

Preview at: https://github.com/prusnak/bitcoin/blob/dependencies/doc/dependencies.md

@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 21, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #22644 (Deprecate UPnP support, require 2.1 or later by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

doc/dependencies.md Outdated Show resolved Hide resolved
@laanwj
Copy link
Member

laanwj commented Apr 4, 2022

Concept ACK

@prusnak
Copy link
Contributor Author

prusnak commented Apr 13, 2022

Rebased => 39bd684

@prusnak prusnak force-pushed the dependencies branch 3 times, most recently from d88cf0d to 128e4ed Compare April 15, 2022 08:56
doc/dependencies.md Outdated Show resolved Hide resolved
@mruddy
Copy link
Contributor

mruddy commented Apr 17, 2022

Concept ACK with the one zeromq nit that you can choose to address or not as it's a matter of opinion

doc/dependencies.md Outdated Show resolved Hide resolved
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK abcb876 - I didn't click on or test all of the links, but this looks ok.

@fanquake fanquake merged commit 1c6fcea into bitcoin:master Apr 21, 2022
@prusnak prusnak deleted the dependencies branch April 21, 2022 09:41
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 22, 2022
abcb876  doc: add more info to dependencies.md (Pavol Rusnak)

Pull request description:

  Follow-up to bitcoin#23565

  I added more info to dependencies.md - especially links to `depends/packages/*.mk` files and link to PRs where used versions were bumped.

  Preview at: https://github.com/prusnak/bitcoin/blob/dependencies/doc/dependencies.md

ACKs for top commit:
  fanquake:
    ACK abcb876 - I didn't click on or test all of the links, but this looks ok.

Tree-SHA512: e91deb639afebeb37f7bf05dddad8f70547b51688e938a30692e59dbd7c9e49d52b7f9bfacb74ef60c98862b6f8f444199d0ae06973c42dc647314bc1ffc22d5
@bitcoin bitcoin locked and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants