build: require libtool 2.4.2 #24650
build: require libtool 2.4.2 #24650
Conversation
|
Concept ACK. Libtool 2.4.2 for OpenBSD? |
+1 for requiring Libtool 2.4.2 (released in 2011) to support OpenBSD |
|
Is there a reason for this bump? Does this have any effect on users or developers? |
|
|
In that case it should be bumped to 1.9, maybe updating the comment to mention the reason. |
I disagree. Firstly, as I mentioned in #24615, I'm not actually sure about the changes there. Secondly, I don't see a reason to not require a more modern version. For example, pre-2.4 libtool doesn't support sysroot, and I don't think pre-2.2.8 libtool properly supported 64 bit Windows builds (via mingw64), so updating to a more modern requirement actually reflects reality, rather than us pretending to support a libtool version that very likely just wouldn't work, and certainly, nobody is testing. OpenBSD using 2.4.2 is a bit odd, and I'm curious to know why they might have remained pinned to an older version. However if that is the case, I think we should set our requirement to 2.4.2; then we are also able to assume improved LTO support when using GCC. |
Every system we support has 2.4.6 available, except for OpenBSD, which currently ships with 2.4.2 (released 2011). For now, set our minimum required version to that. After a 7 year hitus, 2.4.7 has also very recently been released: https://savannah.gnu.org/forum/forum.php?forum_id=10139. Partially motivated by comments in bitcoin#24615. See also: https://repology.org/project/libtool/versions
fanquake
force-pushed
the
require_libtool_2_4_6
branch
from
1dfe4b5
to
061accf
Compare
I think even when there isn't a direct, user-visible improvement, making the requirements stated in the build system, better reflect reality, is worthwhile. I've change this to requiring 2.4.2. I'm not quite sure why OpenBSD is still using 2.4.2 (https://github.com/openbsd/ports/blob/master/devel/libtool/Makefile). Other BSDs, i.e FreeBSD, ship with 2.4.6, and OpenBSD ships with modern versions of other GNU tools, i.e automake, autoconf. |
|
ACK 061accf |
061accf build: require libtool 2.4.2 (fanquake) Pull request description: Every system we support has 2.4.6 available, except for OpenBSD, which [currently ships with 2.4.2](https://github.com/openbsd/ports/blob/master/devel/libtool/Makefile) (released 2011). For now, set our minimum required version to that. After a 7 year hitus, 2.4.7 has also very recently been released: https://savannah.gnu.org/forum/forum.php?forum_id=10139. Partially motivated by comments in bitcoin#24615. See also: https://repology.org/project/libtool/versions ACKs for top commit: achow101: ACK 061accf hebasto: ACK 061accf prusnak: ACK 061accf Tree-SHA512: bc032022b8609b73253ff1c4fd480f4d09be761b8fec295f39319f9499ee2df116f55295da476be551c43ed88fbb0bfed7bb5a188b9979b34147fe39737ec76f
Every system we support has 2.4.6 available, except for OpenBSD, which
currently ships with 2.4.2 (released 2011). For now, set our minimum
required version to that.
After a 7 year hitus, 2.4.7 has also very recently been released:
https://savannah.gnu.org/forum/forum.php?forum_id=10139.
Partially motivated by comments in #24615.
See also: https://repology.org/project/libtool/versions