lint: remove boost::bind lint #24785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think we need to maintain a linter for reintroducing boost::bind at this point.
hebasto
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
ACK 4105a54, I have reviewed the code and it looks OK, I agree it can be merged.
The boost/bind/bind.hpp header is even not allowed by lint-includes.sh.
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 6, 2022
4105a54 lint: remove boost::bind linter (fanquake) Pull request description: I don't think we need to maintain a linter for reintroducing boost::bind at this point. ACKs for top commit: hebasto: ACK 4105a54, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 86bda91ee7ed11f0aa7ac95e9e7b62dbba626dcea75444d2851a3d40e794ab16bef09a1f0c956a716d43602b23c1cf67e1ff3a51184ea1ee7d686fbb76316cb0
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Apr 7, 2022
4105a54 lint: remove boost::bind linter (fanquake) Pull request description: I don't think we need to maintain a linter for reintroducing boost::bind at this point. ACKs for top commit: hebasto: ACK 4105a54, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 86bda91ee7ed11f0aa7ac95e9e7b62dbba626dcea75444d2851a3d40e794ab16bef09a1f0c956a716d43602b23c1cf67e1ff3a51184ea1ee7d686fbb76316cb0
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Apr 7, 2022
4105a54 lint: remove boost::bind linter (fanquake) Pull request description: I don't think we need to maintain a linter for reintroducing boost::bind at this point. ACKs for top commit: hebasto: ACK 4105a54, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 86bda91ee7ed11f0aa7ac95e9e7b62dbba626dcea75444d2851a3d40e794ab16bef09a1f0c956a716d43602b23c1cf67e1ff3a51184ea1ee7d686fbb76316cb0
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Apr 7, 2022
Merge bitcoin#24785: lint: remove boost::bind lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we need to maintain a linter for reintroducing boost::bind at this point.