lint: convert lint-python-mutable-default-parameters.sh to Python #24800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
reviewed
Apr 8, 2022
| def main(): | ||
| command = "git grep -E".split(" ") | ||
| command.append(r"^\s*def [a-zA-Z0-9_]+\(.*=\s*(\[|\{)") | ||
| command.extend("-- *.py".split(" ")) |
There was a problem hiding this comment.
lets just write this as command.extend(["--", "*.py"])
There was a problem hiding this comment.
Done, I put the whole command into an array
laanwj
reviewed
Apr 8, 2022
|
|
||
|
|
||
| def main(): | ||
| command = "git grep -E".split(" ") |
There was a problem hiding this comment.
command = ["git", "grep", "-E"], no need to call split here
There was a problem hiding this comment.
Done, I put the whole command into an array
laanwj
reviewed
Apr 8, 2022
| command.append(r"^\s*def [a-zA-Z0-9_]+\(.*=\s*(\[|\{)") | ||
| command.extend("-- *.py".split(" ")) | ||
| output = subprocess.run(command, stdout=subprocess.PIPE, universal_newlines=True) | ||
| output = output.stdout |
There was a problem hiding this comment.
Would prefer to use output.stdout in following code instead of this assignment.
|
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits |
Change permission Change argument so that it's compatiable with python 3.6 Change comment to docstring Remove .split, .append, .extend calls. Remove 'output' variable assignment
KevinMusgrave
force-pushed
the
port-lint-script-to-python
branch
from
60fe55c
to
e8e48fa
Compare
|
@MarcoFalke Done |
|
review ACK e8e48fa |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 11, 2022
…ters.sh to Python e8e48fa Converted lint-python-mutable-default-parameters.sh to python (TakeshiMusgrave) Pull request description: This converts one of the linter scripts to Python. Reference issue: bitcoin#24783 The approach is to just call git grep using subprocess.run. Alternative approaches could be to use Python instead of git grep (I'm not sure how) or use ```pylint --disable=all --enable=W0102```, though that requires installation of pylint. ACKs for top commit: MarcoFalke: review ACK e8e48fa Tree-SHA512: 7f6f4887dee02c9751b225a6a131fb705868859c4a9af25bb3485cda2358650486b110f17adf89d96a20f212d7d94899922a07aab12c8dc11984cfd5feb7a076
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts one of the linter scripts to Python. Reference issue: #24783
The approach is to just call git grep using subprocess.run.
Alternative approaches could be to use Python instead of git grep (I'm not sure how) or use
pylint --disable=all --enable=W0102, though that requires installation of pylint.