Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: Change log interval to use steady_clock #25104

Merged
merged 1 commit into from May 11, 2022

Conversation

w0xlt
Copy link
Contributor

@w0xlt w0xlt commented May 10, 2022

This refactors the log interval variables to use steady_clock as it is best suitable for measuring intervals.

@w0xlt w0xlt force-pushed the scan_wallet_clovk branch 2 times, most recently from ae6ba79 to 71fbdd6 Compare May 11, 2022 00:12
This refactors the log interval variables to use `steady_clock`
as it is best suitable for measuring intervals.
@dunxen
Copy link
Contributor

dunxen commented May 11, 2022

Concept ACK

Based on the description of steady_clock it seems much better suited to this.

@laanwj
Copy link
Member

laanwj commented May 11, 2022

This makes sense. Code review ACK bdc6881

Copy link
Contributor

@dunxen dunxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK bdc6881

@maflcko maflcko merged commit cca900e into bitcoin:master May 11, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 11, 2022
bdc6881 wallet: Change log interval to use `steady_clock` (w0xlt)

Pull request description:

  This refactors the log interval variables to use `steady_clock` as it is best suitable for measuring intervals.

ACKs for top commit:
  laanwj:
    This makes sense. Code review ACK bdc6881
  dunxen:
    Code review ACK bdc6881

Tree-SHA512: 738b4aa45cef01df77102320f83096a0a7d0c63d7fcf098a8c0ab16b29453a87dc789c110105590e1e215d03499db1d889a94f336dcb385b6883c8364c9d39b7
@w0xlt w0xlt deleted the scan_wallet_clovk branch May 11, 2022 20:50
@bitcoin bitcoin locked and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants