test: Check msg type in msg capture is followed by zeros #25117
Conversation
|
See #21079 |
| assert(len(msgtype) > 0) | ||
| assert(msgtype in MESSAGEMAP) | ||
| assert(len(remainder) == 0 or not remainder.decode().isprintable()) | ||
| assert all(r == 0 for r in remainder) |
There was a problem hiding this comment.
Huh, yes, this is weird code. Agree the new formulation is better.
There was a problem hiding this comment.
Concept ACK
Note that the .split() assignment fails if the raw_msgtype doesn't contain any zeroes:
>>> msgtype, remainder = bytes.fromhex("aabbcc").split(b'\x00', 1)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ValueError: not enough values to unpack (expected 2, got 1)
This problem is not introduced by this PR though; in the master branch it would occur as well:
>>> msgtype = bytes.fromhex("aabbcc").split(b'\x00', 1)[0]
>>> remainder = bytes.fromhex("aabbcc").split(b'\x00', 1)[1]
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
IndexError: list index out of range
I'm confused why this hasn't caused any problems. Whenever a msg-capture file is parsed that contains a message type that consumes the full 12 bytes (i.e. without zero), this should throw. This applies e.g. for sendaddrv2getcfheaders, or getcfcheckpt.
Good point! May be better to use |
|
Thx, used |
Checking that they are not printable is an odd (and wrong) way to check that all chars are zero.