Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Store last/next wallet resend times unique per CWallet object #2541

Merged
merged 1 commit into from
Jul 29, 2013

Conversation

luke-jr
Copy link
Member

@luke-jr luke-jr commented Apr 19, 2013

As soon as we have multiple CWallet objects, this bug would cause them to interfere with each other rebroadcasting.

@sipa
Copy link
Member

sipa commented Apr 23, 2013

Any reason not to just call the variables nNextTime/nLastTime, or rename their usages to nNextRetry/nLastRetry? That reference looks like a hack to avoid code changes :)

@sipa
Copy link
Member

sipa commented Apr 23, 2013

ACK otherwise, by the way.

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/1ee947d0573f8f0b5ae8c5efb27fae376e867187 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@laanwj
Copy link
Member

laanwj commented May 5, 2013

ACK (after squashing into one commit)

Edit: and I agree with @sipa on the use of references, please just rename the variables.

@jgarzik
Copy link
Contributor

jgarzik commented May 30, 2013

ACK, once @laanwj and @sipa comments applied

@luke-jr
Copy link
Member Author

luke-jr commented Jul 17, 2013

Rebased with requested refactor.

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/203d1ae69b1b606c0216d0dc35de567c591720ae for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

sipa added a commit that referenced this pull request Jul 29, 2013
Bugfix: Store last/next wallet resend times unique per CWallet object
@sipa sipa merged commit 4bb77b4 into bitcoin:master Jul 29, 2013
@luke-jr luke-jr deleted the bugfix_wallet_resend branch October 19, 2014 22:18
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants