build: Prevent libtool from hardcoding rpath into binaries #25559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GUIX hashes x86: arm64: |
|
Concept ACK. However I think we should keep this constrained to the Guix build, and the riscv64 HOST. Eventually we should also figure out why this RUNPATH is only being added for riscv64, I assume it's something that could be fixed up in Guix? |
|
Closing this in favour of #25599 for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Libtool hardcodes the rpath into binaries, it may include guix store paths which result in some guix builds being non-reproducible across different architectures. As rpath is not needed, we can just not include it and so configure libtool to not do so.
This provides cross arch reproducibility for riscv64-linux-gnu.
x86_64:
arm64: