depends: compile FastFixedDtoa with -O1 to fix cross-arch reproducibility for arm32 #25643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a non-determinism issue in the asm produced for this function when cross-compiling on x86_64 and aarch64 for the arm-linux-gnueabihf HOST. Related to bitcoin#21194.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Guix builds:
|
hebasto
approved these changes
Jul 19, 2022
|
GUIX hashes: x86: arm64: |
jarolrod
approved these changes
Jul 19, 2022
|
ACK c32fa85 x86_64: arm64: |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 20, 2022
…ross-arch reproducibility for arm32 c32fa85 depends: modify FastFixedDtoa optimisation flags (fanquake) Pull request description: This fixes a non-determinism issue in the asm produced for this function when cross-compiling on x86_64 and aarch64 for the arm-linux-gnueabihf HOST. Related to bitcoin#21194. Alternative to bitcoin#25636. Initial discussion in bitcoin#24615 (comment). Guix Build (x86_64): ```bash 28ae0ec2874ead334edd1c5dc509344379d82f7058b649c9076992defd7190d7 guix-build-c32fa85909dd/output/arm-linux-gnueabihf/SHA256SUMS.part 48d34073b029c4f62c8e1bd906533610228d5ca0bb5eefea6010dfa7372ba067 guix-build-c32fa85909dd/output/arm-linux-gnueabihf/bitcoin-c32fa85909dd-arm-linux-gnueabihf-debug.tar.gz 850d6e9859e88bcb93ed586bdb0c0bc95a44249d6a0ec1b1d13125cb9dd56413 guix-build-c32fa85909dd/output/arm-linux-gnueabihf/bitcoin-c32fa85909dd-arm-linux-gnueabihf.tar.gz b8bb092b1307684ea4b53d810ac110ec14f29eeab8028d924d1cac7418009b14 guix-build-c32fa85909dd/output/dist-archive/bitcoin-c32fa85909dd.tar.gz ``` Guix Build (arm64): ```bash 28ae0ec2874ead334edd1c5dc509344379d82f7058b649c9076992defd7190d7 guix-build-c32fa85909dd/output/arm-linux-gnueabihf/SHA256SUMS.part 48d34073b029c4f62c8e1bd906533610228d5ca0bb5eefea6010dfa7372ba067 guix-build-c32fa85909dd/output/arm-linux-gnueabihf/bitcoin-c32fa85909dd-arm-linux-gnueabihf-debug.tar.gz 850d6e9859e88bcb93ed586bdb0c0bc95a44249d6a0ec1b1d13125cb9dd56413 guix-build-c32fa85909dd/output/arm-linux-gnueabihf/bitcoin-c32fa85909dd-arm-linux-gnueabihf.tar.gz b8bb092b1307684ea4b53d810ac110ec14f29eeab8028d924d1cac7418009b14 guix-build-c32fa85909dd/output/dist-archive/bitcoin-c32fa85909dd.tar.gz ``` ACKs for top commit: achow101: ACK c32fa85 hebasto: ACK c32fa85 jarolrod: ACK c32fa85 Tree-SHA512: 137d76274b1421247f43e5f040b4b5c42473f94d734498c73ab40e580c47dfecbbf11f1a69c15a87d805d4b8e9ef1fd62cc1b69c0f1614c62ff3cba98b1733e8
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
May 9, 2023
… reproducibility for arm32
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
May 9, 2023
… reproducibility for arm32
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 26, 2023
Summary: This brings us to the same set of patches as the current tip of the Core repository, minus the ones for architectures we don't support (mainly android and arm64 MacOS) > build, qt: Hardcode last modified timestamp in Qt RCC > > This change allows the already built qt package to be reused even with > the SOURCE_DATE_EPOCH variable set, e.g., for Guix builds. > build: patch around qt duplicate symbol issue > > This is currently causing the same failure in two different PRs: > ```bash > duplicate symbol 'lcQpaFonts()' in: > /tmp/cirrus-ci-build/depends/x86_64-apple-darwin/lib/libQt5ThemeSupport.a(qgenericunixthemes.o) > /tmp/cirrus-ci-build/depends/x86_64-apple-darwin/lib/libQt5FontDatabaseSupport.a(qfontengine_coretext.o) > ld: 1 duplicate symbol for architecture x86_64 > ``` > > ```bash > x86_64-apple-darwin-ld: error: duplicate symbol: __Z10lcQpaFontsv > >>> defined in /tmp/cirrus-ci-build/depends/x86_64-apple-darwin/lib/libQt5ThemeSupport.a(qgenericunixthemes.o) > >>> defined in /tmp/cirrus-ci-build/depends/x86_64-apple-darwin/lib/libQt5FontDatabaseSupport.a(qfontengine_coretext.o) > ``` > > Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> > > depends: modify FastFixedDtoa optimisation flags > > This fixes a non-determinism issue in the asm produced for > this function when cross-compiling on x86_64 and aarch64 for > the arm-linux-gnueabihf HOST. > > Related to #21194. > guix: More thoroughly control native toolchain This patch has been updated (line numbers in the diff only) to account for a Qt version bump (D13918) This is a backport of [[bitcoin/bitcoin#23862 | core#23862]], [[bitcoin/bitcoin#24722 | core#24722]] and [[bitcoin/bitcoin#25643 | core#25643]] and bitcoin/bitcoin@c1ae726 Depends on D13926 Test Plan: local crossbuild of qt, gitian builds, guix build Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D13927
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
May 31, 2023
… reproducibility for arm32
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 8, 2023
… reproducibility for arm32
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 11, 2023
… reproducibility for arm32
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 11, 2023
… reproducibility for arm32
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 19, 2023
… reproducibility for arm32
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 20, 2023
… reproducibility for arm32
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 27, 2023
… reproducibility for arm32
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 27, 2023
… reproducibility for arm32
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 28, 2023
… reproducibility for arm32
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 28, 2023
… reproducibility for arm32
PastaPastaPasta
pushed a commit
to kwvg/dash
that referenced
this pull request
Jun 29, 2023
… reproducibility for arm32
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Jun 29, 2023
backport: merge bitcoin#25643, bitcoin#23583, bitcoin#23618, bitcoin#23603, bitcoin#23817, bitcoin#24520, bitcoin#24508, bitcoin#25639, bitcoin#26018, bitcoin#25437, bitcoin#25484, bitcoin#23585, bitcoin#24549, bitcoin#24733, bitcoin#21991, bitcoin#22526, bitcoin#25633, bitcoin#24597, bitcoin#24955, bitcoin#25099, bitcoin#24552, bitcoin#21851, bitcoin#25389, bitcoin#25357, partial bitcoin#22318 (guix backports: part 3)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a non-determinism issue in the asm produced for
this function when cross-compiling on x86_64 and aarch64 for
the arm-linux-gnueabihf HOST.
Related to #21194. Alternative to #25636. Initial discussion in #24615 (comment).
Guix Build (x86_64):
Guix Build (arm64):