bdb: disable Werror for format-security #25763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is causing build failures in some build environments, like NixOS. I don't think we are going to patch bdb at this point, and this warning has existed for as long as we've used bdb. Fixes bitcoin#25211. Tested (in Docker) with: ```bash docker run -it nixos/nix nix-shell -p gitMinimal gcc12 libtool pkg-config curl gnumake patch autoconf automake git clone https://github.com/bitcoin/bitcoin make -C bitcoin/depends bdb ``` Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 2, 2022
b46c6ec bdb: disable Werror for format-security (fanquake) Pull request description: This is causing build failures in some build environments, like NixOS. I don't think we are going to patch bdb at this point, and this warning has existed for as long as we've used bdb. Fixes bitcoin#25211. Tested (in Docker) with: ```bash docker run -it nixos/nix nix-shell -p gitMinimal gcc12 libtool pkg-config curl gnumake patch autoconf automake git clone https://github.com/bitcoin/bitcoin make -C bitcoin/depends bdb ``` Co-authored-by: Ryan Ofsky <ryan@ofsky.org> Guix Build (x86_64): ```bash 25981417fe09fa9e6f7b30875dac709a1de1146d77ec3c04bbf18eace16932b7 guix-build-b46c6ec52e15/output/aarch64-linux-gnu/SHA256SUMS.part 9edc248dad9508ff7ec1ddc121caa606a2da27f5b36f664cb54b17bcdcfa407e guix-build-b46c6ec52e15/output/aarch64-linux-gnu/bitcoin-b46c6ec52e15-aarch64-linux-gnu-debug.tar.gz e3bac816e7b1ef69927a818e6d882af0bf2dae69930181d4a144bfe309078391 guix-build-b46c6ec52e15/output/aarch64-linux-gnu/bitcoin-b46c6ec52e15-aarch64-linux-gnu.tar.gz d15461bb5fb5abafb3a515fa37e2f6b49a352e22b22d5d93aa4ecf7705781e72 guix-build-b46c6ec52e15/output/arm-linux-gnueabihf/SHA256SUMS.part f3d215bcee1e695a83092841544f00f34cbe65d6d5374673ef3b9a686caaaf85 guix-build-b46c6ec52e15/output/arm-linux-gnueabihf/bitcoin-b46c6ec52e15-arm-linux-gnueabihf-debug.tar.gz e9eb5bca37dfeac5207ec427bbe590528841cb9fb7d4a1e28646ebb00386a72d guix-build-b46c6ec52e15/output/arm-linux-gnueabihf/bitcoin-b46c6ec52e15-arm-linux-gnueabihf.tar.gz d2b13313b5e638d54c77026c8e383c93e32c677fe9b48c457b16d872bf034219 guix-build-b46c6ec52e15/output/arm64-apple-darwin/SHA256SUMS.part 21dc8ac4f0a1535c9459e9be43d65151e4affd7cdd0a65d2e95f6f8fb0960a71 guix-build-b46c6ec52e15/output/arm64-apple-darwin/bitcoin-b46c6ec52e15-arm64-apple-darwin-unsigned.dmg 2dfb444497b71a546e56e0dbc1dc560860006489edfe0cf2e418378ac36c5780 guix-build-b46c6ec52e15/output/arm64-apple-darwin/bitcoin-b46c6ec52e15-arm64-apple-darwin-unsigned.tar.gz 22ebb15f5bec1f5d610dc4706ebbb0977ed013209d73077a3c601e27db6bc37c guix-build-b46c6ec52e15/output/arm64-apple-darwin/bitcoin-b46c6ec52e15-arm64-apple-darwin.tar.gz 320d12f518f899fa1b31ca89553362f8e2855a4ae50e9756e8c12cdfbc4c5392 guix-build-b46c6ec52e15/output/dist-archive/bitcoin-b46c6ec52e15.tar.gz 0c6773c8960746c837e2bd929057dab08f0d2963ef42f0ac071bfcb0fbc57e44 guix-build-b46c6ec52e15/output/powerpc64-linux-gnu/SHA256SUMS.part 2c77c8213fa52bb0395a57d128b179e5615c463e4a4a582b111bf13bb907c293 guix-build-b46c6ec52e15/output/powerpc64-linux-gnu/bitcoin-b46c6ec52e15-powerpc64-linux-gnu-debug.tar.gz 74023867ae64c3b32fccead48b3dcb81c55299a61bd921d22bc3a7c937c253fb guix-build-b46c6ec52e15/output/powerpc64-linux-gnu/bitcoin-b46c6ec52e15-powerpc64-linux-gnu.tar.gz f3fff570610cf13ab77e8ce9b97700b82cf9d3f2ab61662ca49b2c99be824ae2 guix-build-b46c6ec52e15/output/powerpc64le-linux-gnu/SHA256SUMS.part a638b18d3281253ad20d54e1dfd83157d6d38c6bd90a30f724de1d29d416aff5 guix-build-b46c6ec52e15/output/powerpc64le-linux-gnu/bitcoin-b46c6ec52e15-powerpc64le-linux-gnu-debug.tar.gz 340f56a514437cf25e75c14d3c90084f67b7c9cd0b304739033db17c9978c754 guix-build-b46c6ec52e15/output/powerpc64le-linux-gnu/bitcoin-b46c6ec52e15-powerpc64le-linux-gnu.tar.gz 35c06a9e06fded9bdaff53c2f142c03e5dc255c3fdfa8bad0af068a29b488471 guix-build-b46c6ec52e15/output/riscv64-linux-gnu/SHA256SUMS.part 049d06931661ab0f1cbcb37217083c35b809187a6bc51d7173c54c237ee1160d guix-build-b46c6ec52e15/output/riscv64-linux-gnu/bitcoin-b46c6ec52e15-riscv64-linux-gnu-debug.tar.gz a128abdd8898a7fb75f1b293141ec64ef70129576f61415025187d3cb9f2ecc6 guix-build-b46c6ec52e15/output/riscv64-linux-gnu/bitcoin-b46c6ec52e15-riscv64-linux-gnu.tar.gz 184be693f9633b0642bd75065d7bdf964cec9485af167504eea32d2d8aff8075 guix-build-b46c6ec52e15/output/x86_64-apple-darwin/SHA256SUMS.part 53ab2fb050533dc9a0f7b301b53d47ca65484f4e4eeea3b1259c353dd2cde4f2 guix-build-b46c6ec52e15/output/x86_64-apple-darwin/bitcoin-b46c6ec52e15-x86_64-apple-darwin-unsigned.dmg 5d92fcb539b41fb3b41bd1878025ecbb958521caf7eae8c3ae796aa4f235a982 guix-build-b46c6ec52e15/output/x86_64-apple-darwin/bitcoin-b46c6ec52e15-x86_64-apple-darwin-unsigned.tar.gz be71b8da7fa0ac39a3f8191293326b300b93b8fe4efba732a78366aebbb971b9 guix-build-b46c6ec52e15/output/x86_64-apple-darwin/bitcoin-b46c6ec52e15-x86_64-apple-darwin.tar.gz 07c195ad1ad1b00f5062d405913169367b73363a0418330c6add394c9df6e30b guix-build-b46c6ec52e15/output/x86_64-linux-gnu/SHA256SUMS.part 4c11ba2d5a38921511b0fc88b1aca0e30f939291176d2c1f93b211d63b04fd45 guix-build-b46c6ec52e15/output/x86_64-linux-gnu/bitcoin-b46c6ec52e15-x86_64-linux-gnu-debug.tar.gz 694d21edd3f462163ecf5821dae74b39c9ee4fc4f5697fe5865a71a7e3dc24dc guix-build-b46c6ec52e15/output/x86_64-linux-gnu/bitcoin-b46c6ec52e15-x86_64-linux-gnu.tar.gz 9b66a629a38e37b2746f237289bf4287184605876583ce24a073e42136e840af guix-build-b46c6ec52e15/output/x86_64-w64-mingw32/SHA256SUMS.part 7a8d633ac6f2c4a4955fb6dcc64b7560d96bfa74516ab2799ea7fc1b90c58b2f guix-build-b46c6ec52e15/output/x86_64-w64-mingw32/bitcoin-b46c6ec52e15-win64-debug.zip 81169a19c0a954949293fee2c8825a86bfb36a3a34c4c0271d926982cad626e2 guix-build-b46c6ec52e15/output/x86_64-w64-mingw32/bitcoin-b46c6ec52e15-win64-setup-unsigned.exe 58be54d27b308f07609447ae6fca8a91e76630d7753adb54e200c576fee8e6c0 guix-build-b46c6ec52e15/output/x86_64-w64-mingw32/bitcoin-b46c6ec52e15-win64-unsigned.tar.gz f13243cb6527bf7e9182673d32ccee32cb160d404271a0057e092a1cb571cc29 guix-build-b46c6ec52e15/output/x86_64-w64-mingw32/bitcoin-b46c6ec52e15-win64.zip ``` Guix Build (arm64): ```bash d15461bb5fb5abafb3a515fa37e2f6b49a352e22b22d5d93aa4ecf7705781e72 guix-build-b46c6ec52e15/output/arm-linux-gnueabihf/SHA256SUMS.part f3d215bcee1e695a83092841544f00f34cbe65d6d5374673ef3b9a686caaaf85 guix-build-b46c6ec52e15/output/arm-linux-gnueabihf/bitcoin-b46c6ec52e15-arm-linux-gnueabihf-debug.tar.gz e9eb5bca37dfeac5207ec427bbe590528841cb9fb7d4a1e28646ebb00386a72d guix-build-b46c6ec52e15/output/arm-linux-gnueabihf/bitcoin-b46c6ec52e15-arm-linux-gnueabihf.tar.gz f699f38a59bc888d5b728c934d1bf2a30dc46e6e0dfe4f6109c90c1e557b6334 guix-build-b46c6ec52e15/output/arm64-apple-darwin/SHA256SUMS.part e60d6ea30c18bfc948e146f6e8a6d9d53c84500c2117472999bc60e1bfa2dc4a guix-build-b46c6ec52e15/output/arm64-apple-darwin/bitcoin-b46c6ec52e15-arm64-apple-darwin-unsigned.dmg 8f5693a12671ea789e885b40dfeefdf076dd6f9856bfa867f33b7e1005779dd4 guix-build-b46c6ec52e15/output/arm64-apple-darwin/bitcoin-b46c6ec52e15-arm64-apple-darwin-unsigned.tar.gz a56b01ad6bf161f4cd7e3f89faea5b464460093131400df8f89c3b78839a72a9 guix-build-b46c6ec52e15/output/arm64-apple-darwin/bitcoin-b46c6ec52e15-arm64-apple-darwin.tar.gz 320d12f518f899fa1b31ca89553362f8e2855a4ae50e9756e8c12cdfbc4c5392 guix-build-b46c6ec52e15/output/dist-archive/bitcoin-b46c6ec52e15.tar.gz 0c6773c8960746c837e2bd929057dab08f0d2963ef42f0ac071bfcb0fbc57e44 guix-build-b46c6ec52e15/output/powerpc64-linux-gnu/SHA256SUMS.part 2c77c8213fa52bb0395a57d128b179e5615c463e4a4a582b111bf13bb907c293 guix-build-b46c6ec52e15/output/powerpc64-linux-gnu/bitcoin-b46c6ec52e15-powerpc64-linux-gnu-debug.tar.gz 74023867ae64c3b32fccead48b3dcb81c55299a61bd921d22bc3a7c937c253fb guix-build-b46c6ec52e15/output/powerpc64-linux-gnu/bitcoin-b46c6ec52e15-powerpc64-linux-gnu.tar.gz f3fff570610cf13ab77e8ce9b97700b82cf9d3f2ab61662ca49b2c99be824ae2 guix-build-b46c6ec52e15/output/powerpc64le-linux-gnu/SHA256SUMS.part a638b18d3281253ad20d54e1dfd83157d6d38c6bd90a30f724de1d29d416aff5 guix-build-b46c6ec52e15/output/powerpc64le-linux-gnu/bitcoin-b46c6ec52e15-powerpc64le-linux-gnu-debug.tar.gz 340f56a514437cf25e75c14d3c90084f67b7c9cd0b304739033db17c9978c754 guix-build-b46c6ec52e15/output/powerpc64le-linux-gnu/bitcoin-b46c6ec52e15-powerpc64le-linux-gnu.tar.gz 35c06a9e06fded9bdaff53c2f142c03e5dc255c3fdfa8bad0af068a29b488471 guix-build-b46c6ec52e15/output/riscv64-linux-gnu/SHA256SUMS.part 049d06931661ab0f1cbcb37217083c35b809187a6bc51d7173c54c237ee1160d guix-build-b46c6ec52e15/output/riscv64-linux-gnu/bitcoin-b46c6ec52e15-riscv64-linux-gnu-debug.tar.gz a128abdd8898a7fb75f1b293141ec64ef70129576f61415025187d3cb9f2ecc6 guix-build-b46c6ec52e15/output/riscv64-linux-gnu/bitcoin-b46c6ec52e15-riscv64-linux-gnu.tar.gz 184be693f9633b0642bd75065d7bdf964cec9485af167504eea32d2d8aff8075 guix-build-b46c6ec52e15/output/x86_64-apple-darwin/SHA256SUMS.part 53ab2fb050533dc9a0f7b301b53d47ca65484f4e4eeea3b1259c353dd2cde4f2 guix-build-b46c6ec52e15/output/x86_64-apple-darwin/bitcoin-b46c6ec52e15-x86_64-apple-darwin-unsigned.dmg 5d92fcb539b41fb3b41bd1878025ecbb958521caf7eae8c3ae796aa4f235a982 guix-build-b46c6ec52e15/output/x86_64-apple-darwin/bitcoin-b46c6ec52e15-x86_64-apple-darwin-unsigned.tar.gz be71b8da7fa0ac39a3f8191293326b300b93b8fe4efba732a78366aebbb971b9 guix-build-b46c6ec52e15/output/x86_64-apple-darwin/bitcoin-b46c6ec52e15-x86_64-apple-darwin.tar.gz 07c195ad1ad1b00f5062d405913169367b73363a0418330c6add394c9df6e30b guix-build-b46c6ec52e15/output/x86_64-linux-gnu/SHA256SUMS.part 4c11ba2d5a38921511b0fc88b1aca0e30f939291176d2c1f93b211d63b04fd45 guix-build-b46c6ec52e15/output/x86_64-linux-gnu/bitcoin-b46c6ec52e15-x86_64-linux-gnu-debug.tar.gz 694d21edd3f462163ecf5821dae74b39c9ee4fc4f5697fe5865a71a7e3dc24dc guix-build-b46c6ec52e15/output/x86_64-linux-gnu/bitcoin-b46c6ec52e15-x86_64-linux-gnu.tar.gz 9b66a629a38e37b2746f237289bf4287184605876583ce24a073e42136e840af guix-build-b46c6ec52e15/output/x86_64-w64-mingw32/SHA256SUMS.part 7a8d633ac6f2c4a4955fb6dcc64b7560d96bfa74516ab2799ea7fc1b90c58b2f guix-build-b46c6ec52e15/output/x86_64-w64-mingw32/bitcoin-b46c6ec52e15-win64-debug.zip 81169a19c0a954949293fee2c8825a86bfb36a3a34c4c0271d926982cad626e2 guix-build-b46c6ec52e15/output/x86_64-w64-mingw32/bitcoin-b46c6ec52e15-win64-setup-unsigned.exe 58be54d27b308f07609447ae6fca8a91e76630d7753adb54e200c576fee8e6c0 guix-build-b46c6ec52e15/output/x86_64-w64-mingw32/bitcoin-b46c6ec52e15-win64-unsigned.tar.gz f13243cb6527bf7e9182673d32ccee32cb160d404271a0057e092a1cb571cc29 guix-build-b46c6ec52e15/output/x86_64-w64-mingw32/bitcoin-b46c6ec52e15-win64.zip ``` ACKs for top commit: ryanofsky: Code review ACK b46c6ec. Thanks for addressing build issue. Probably there is no real security issue, but could look into that jarolrod: Code Review ACK b46c6ec Tree-SHA512: 4b6b98e225e9b98fe1426a6402dae28e30327c932268d9bec31bf84aee12ec609ce97bd89a592a1f2cfd4d031ba520130bfef95006f7e09c0692af233f9614bb
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Apr 18, 2023
This is causing build failures in some build environments, like NixOS. I don't think we are going to patch bdb at this point, and this warning has existed for as long as we've used bdb. Fixes bitcoin#25211. Tested (in Docker) with: ```bash docker run -it nixos/nix nix-shell -p gitMinimal gcc12 libtool pkg-config curl gnumake patch autoconf automake git clone https://github.com/bitcoin/bitcoin make -C bitcoin/depends bdb ``` Co-authored-by: Ryan Ofsky <ryan@ofsky.org> Github-Pull: bitcoin#25763 Rebased-From: b46c6ec
fanquake
added a commit
that referenced
this pull request
May 1, 2023
f091933 depends: fix compiling bdb with clang-16 on aarch64 (fanquake) c14f3b3 bdb: disable Werror for format-security (fanquake) ec7a883 build: suppress array-bounds errors in libxkbcommon (fanquake) Pull request description: Any further backports for 23.x. Currently: * 1bdbbbd from #25436 - which fixes building QT in depends with GCC > 12.1 * #25763 * #27462 ACKs for top commit: TheCharlatan: ACK f091933 Tree-SHA512: 8432ae37906e347ed30e2adc99a8b51e7f44159d04244fa749c5666c3b27cdd4fa89394c41674f980c09cc6c11367c3ee9c0922a2a8bd65ea471f9fd71a108ad
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing build failures in some build environments, like NixOS.
I don't think we are going to patch bdb at this point, and this warning
has existed for as long as we've used bdb.
Fixes #25211.
Tested (in Docker) with:
Co-authored-by: Ryan Ofsky ryan@ofsky.org
Guix Build (x86_64):
Guix Build (arm64):