Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripted-diff: rpc: fix rescan RPC name (s/rescanwallet/rescanblockchain/) #25924

Conversation

theStack
Copy link
Contributor

There is no RPC call named rescanwallet, i.e. fix this by renaming to the actual RPC called rescanblockchain.

…ain/)

There is no RPC call named `rescanwallet`, i.e. fix this by renaming to
the actual RPC called `rescanblockchain`.

-BEGIN VERIFY SCRIPT-
sed -i s/rescanwallet/rescanblockchain/ $(git grep -l rescanwallet)
-END VERIFY SCRIPT-
@achow101
Copy link
Member

ACK e90a445

Copy link
Member

@aureleoules aureleoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e90a445.
Verified there isn't a rescanwallet rpc and should be rescanblockchain instead.

Copy link
Member

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e90a445

@achow101 achow101 merged commit bbbc26d into bitcoin:master Aug 25, 2022
@theStack theStack deleted the 202208-rename_rescanwallet_to_rescanblockchain branch August 25, 2022 21:29
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 26, 2022
…nwallet/rescanblockchain/)

e90a445 scripted-diff: rpc: fix rescan RPC name (s/rescanwallet/rescanblockchain/) (Sebastian Falbesoner)

Pull request description:

  There is no RPC call named `rescanwallet`, i.e. fix this by renaming to the actual RPC called `rescanblockchain`.

ACKs for top commit:
  achow101:
    ACK e90a445
  aureleoules:
    ACK e90a445.
  promag:
    ACK e90a445

Tree-SHA512: abf1d1c18de32d87c29e4ff2b782dfb0e4a46dc2c2cc51ab616d12674a0f4a5d22214e00955663ae897cbb88f4f6ced913850f28ea3f5c1b3a54577a25fbf399
@bitcoin bitcoin locked and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants