Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: wait for the expected basic block filter index in interface_rest #26143

Merged
merged 1 commit into from Sep 21, 2022

Conversation

brunoerg
Copy link
Contributor

Fixes #26098

Wait for the expected 'basic block filter index' to not cause issues when calling /blockfilterheaders/basic/, like:

bitcoin/src/rest.cpp

Lines 423 to 424 in 9bd842a

if (!index_ready) {
errmsg += " Block filters are still in the process of being indexed.";

@fanquake fanquake added the Tests label Sep 20, 2022
Copy link

@amovfx amovfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, everything works on local build, checks and test/functional/interface_rest.py.

@maflcko maflcko merged commit 7184fb8 into bitcoin:master Sep 21, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Sep 23, 2022
…ndex in `interface_rest`

aee29c5 test: wait for the expected basic block filter index in `interface_rest` (brunoerg)

Pull request description:

  Fixes bitcoin#26098

  Wait for the expected 'basic block filter index' to not cause issues when calling `/blockfilterheaders/basic/`, like:
  https://github.com/bitcoin/bitcoin/blob/9bd842a5928f160c1bc8fca6ca7d8d43f096fd6a/src/rest.cpp#L423-L424

Top commit has no ACKs.

Tree-SHA512: 36abe28a76cd01ce7ac1ae9258ce1a9a5473d985c498d915c1130256bc800d0d1207708a195b78bbcb00478ec9c373a2fbfeb26c1fddeb35abe8b253e0308058
@bitcoin bitcoin locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: failure in interface_rest.py
4 participants