Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use git2.34 for lint task #26195

Merged
merged 1 commit into from Sep 29, 2022
Merged

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Sep 28, 2022

Since most maintainers use a recent version of git that uses the ort strategy by default (https://git-scm.com/docs/merge-strategies/2.34.0), bump git for the lint taks as well.

Fixes #26130 (comment)

@luke-jr
Copy link
Member

luke-jr commented Sep 28, 2022

Seems like this could unintentionally bump other deps/libs as well. Maybe just wget the one package?

@maflcko
Copy link
Member Author

maflcko commented Sep 28, 2022

The only other thing we care about (a bit) is the python version. Since we don't care too much about it, the alternative would be to just bump completely to jammy

@DrahtBot DrahtBot added the Tests label Sep 28, 2022
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d8ded8b - seems fine for now, and to keep python3.6 around. When we bump to >= Jammy in future we'll have to pick from Python3.10+.

@fanquake fanquake linked an issue Sep 29, 2022 that may be closed by this pull request
@maflcko maflcko merged commit 291e363 into bitcoin:master Sep 29, 2022
@maflcko maflcko deleted the 2209-lint-git-🗞 branch September 29, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants