New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kernel: move RunCommandParseJSON to its own file #26196
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
// Copyright (c) 2022 The Bitcoin Core developers | ||
// Distributed under the MIT software license, see the accompanying | ||
// file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||
|
||
#if defined(HAVE_CONFIG_H) | ||
#include <config/bitcoin-config.h> | ||
#endif | ||
|
||
#include <common/run_command.h> | ||
|
||
#include <tinyformat.h> | ||
#include <univalue.h> | ||
|
||
#ifdef ENABLE_EXTERNAL_SIGNER | ||
#if defined(__GNUC__) | ||
// Boost 1.78 requires the following workaround. | ||
// See: https://github.com/boostorg/process/issues/235 | ||
#pragma GCC diagnostic push | ||
#pragma GCC diagnostic ignored "-Wnarrowing" | ||
#endif | ||
#include <boost/process.hpp> | ||
#if defined(__GNUC__) | ||
#pragma GCC diagnostic pop | ||
#endif | ||
#endif // ENABLE_EXTERNAL_SIGNER | ||
|
||
UniValue RunCommandParseJSON(const std::string& str_command, const std::string& str_std_in) | ||
{ | ||
#ifdef ENABLE_EXTERNAL_SIGNER | ||
namespace bp = boost::process; | ||
|
||
UniValue result_json; | ||
bp::opstream stdin_stream; | ||
bp::ipstream stdout_stream; | ||
bp::ipstream stderr_stream; | ||
|
||
if (str_command.empty()) return UniValue::VNULL; | ||
|
||
bp::child c( | ||
str_command, | ||
bp::std_out > stdout_stream, | ||
bp::std_err > stderr_stream, | ||
bp::std_in < stdin_stream | ||
); | ||
if (!str_std_in.empty()) { | ||
stdin_stream << str_std_in << std::endl; | ||
} | ||
stdin_stream.pipe().close(); | ||
|
||
std::string result; | ||
std::string error; | ||
std::getline(stdout_stream, result); | ||
std::getline(stderr_stream, error); | ||
|
||
c.wait(); | ||
const int n_error = c.exit_code(); | ||
if (n_error) throw std::runtime_error(strprintf("RunCommandParseJSON error: process(%s) returned %d: %s\n", str_command, n_error, error)); | ||
if (!result_json.read(result)) throw std::runtime_error("Unable to parse JSON: " + result); | ||
|
||
return result_json; | ||
#else | ||
throw std::runtime_error("Compiled without external signing support (required for external signing)."); | ||
#endif // ENABLE_EXTERNAL_SIGNER | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// Copyright (c) 2022 The Bitcoin Core developers | ||
// Distributed under the MIT software license, see the accompanying | ||
// file COPYING or http://www.opensource.org/licenses/mit-license.php. | ||
|
||
#ifndef BITCOIN_COMMON_RUN_COMMAND_H | ||
#define BITCOIN_COMMON_RUN_COMMAND_H | ||
|
||
#include <string> | ||
|
||
class UniValue; | ||
|
||
/** | ||
* Execute a command which returns JSON, and parse the result. | ||
* | ||
* @param str_command The command to execute, including any arguments | ||
* @param str_std_in string to pass to stdin | ||
* @return parsed JSON | ||
*/ | ||
UniValue RunCommandParseJSON(const std::string& str_command, const std::string& str_std_in=""); | ||
|
||
#endif // BITCOIN_COMMON_RUN_COMMAND_H |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pico-nit: Shouldn't this be in the very first line after the comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look at the follow up for moving more code, and could address as part of that.