test: Test year 2106 block timestamps #26259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
2210-test-2106-
branch
from
bbbb54b
to
cccccc5
Compare
Sjors
reviewed
Oct 6, 2022
Sjors
reviewed
Oct 6, 2022
| time_2106 = 2**32 - 1 | ||
| self.nodes[0].setmocktime(time_2106) | ||
| last = self.generate(self.nodes[0], 6)[-1] | ||
| assert_equal(self.nodes[0].getblockheader(last)["mediantime"], time_2106) |
There was a problem hiding this comment.
Might as well generate one more block to trigger the (other) 2106 bug: time-too-old, block's timestamp is too early
There was a problem hiding this comment.
I'd rather not, because this would require the whole file to be ignored by the implicit-signed-integer-truncation sanitizer:
node0 stderr node/miner.cpp:36:25: runtime error: implicit conversion from type 'int64_t' (aka 'long') of value 4294967296 (64-bit, signed) to type 'uint32_t' (aka 'unsigned int') changed the value to 0 (32-bit, unsigned)
* Use maximum timestamp in getblocktemplate test * Mine block with maximum timestamp and MTP in blockchain test
maflcko
force-pushed
the
2210-test-2106-
branch
from
cccccc5
to
fafc96a
Compare
|
utACK fafc96a |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 23, 2022
fafc96a test: Test year 2106 block timestamps (MacroFake) Pull request description: Alternative to bitcoin#21362 that closes bitcoin#21356 ACKs for top commit: Sjors: utACK fafc96a Tree-SHA512: 196d98f42d6f7f0222312b7bd1c68b3bd30cb6f0cbaccb900cfc5fcc689494adb2a7d7d6023c1ff1e8cf871047ec37eeca41386e31029d99cabf9343b4fd2a03
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #21362 that closes #21356