New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rename local variable to distinguish it from type alias #26624
Conversation
The `txiter` type alias is declared in the `txmempool.h`.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 1984db1
Straightforward change, better to not have naming conflicts.
auto tx_iter = m_mempool.GetIter(tx->GetHash()); | ||
if (tx_iter) { | ||
const CTxMemPoolEntry::Parents& parents = (*tx_iter)->GetMemPoolParentsConst(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, while touching:
auto tx_iter = m_mempool.GetIter(tx->GetHash()); | |
if (tx_iter) { | |
const CTxMemPoolEntry::Parents& parents = (*tx_iter)->GetMemPoolParentsConst(); | |
auto tx_iter{m_mempool.GetIter(tx->GetHash())}; | |
if (tx_iter) { | |
const CTxMemPoolEntry::Parents& parents{(*tx_iter)->GetMemPoolParentsConst()}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 1984db1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 1984db1
I have reviewed the code and agree it can be merged.
The
txiter
type alias is declared in thetxmempool.h
:bitcoin/src/txmempool.h
Line 406 in 9e59d21