refactor: make some BlockManager members const

[promag]

These methods can be const so make them const 🤷

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #26533 (prune: scan and unlink already pruned block files on startup by andrewtoth)
• #26415 (rpc,rest,zmq: faster getblock, NotifyBlock and rest_block by reading raw block by andrewtoth)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[fanquake]

See also #25673, which came with the CI check.

[promag]

@fanquake d0efa0c is the motivation for this change, making blockman usage const.

[TheCharlatan]

Concept ACK

It won't make a difference to any callers of the BlockManager, but I think you could mark FlushUndoFile as const as well.

[DrahtBot]

🐙 This pull request conflicts with the target branch and needs rebase.

[achow101]

The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

Closing due to lack of interest. Pull requests with improvements are always welcome.