refactor: Add missing includes to fix gcc-13 compile error

[maflcko]

On current master:

  CXX      support/libbitcoin_util_a-lockedpool.o
support/lockedpool.cpp: In member function ‘void Arena::free(void*)’:
support/lockedpool.cpp:99:20: error: ‘runtime_error’ is not a member of ‘std’
   99 |         throw std::runtime_error("Arena: invalid or double free");
      |                    ^~~~~~~~~~~~~
support/lockedpool.cpp:22:1: note: ‘std::runtime_error’ is defined in header ‘<stdexcept>’; did you forget to ‘#include <stdexcept>’?
   21 | #include <algorithm>
  +++ |+#include <stdexcept>
   22 | #ifdef ARENA_DEBUG
support/lockedpool.cpp: In member function ‘void LockedPool::free(void*)’:
support/lockedpool.cpp:320:16: error: ‘runtime_error’ is not a member of ‘std’
  320 |     throw std::runtime_error("LockedPool: invalid address not pointing to any arena");
      |                ^~~~~~~~~~~~~
support/lockedpool.cpp:320:16: note: ‘std::runtime_error’ is defined in header ‘<stdexcept>’; did you forget to ‘#include <stdexcept>’?

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto, fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

[hebasto]

ACK fadeb6b.

While touching headers, the unused #include <config/bitcoin-config.h> can be removed as well.

And IWYU suggests to drop #include <limits.h>. But there could be some platform-specific pitfalls. FWIW, on my machine, the limits.h does not contain #define PAGESIZE.

[fanquake]

ACK fadeb6b - tested this fixes compilation with GCC 13. I don't think theres a need to do anything else here, and that'd also just potentially complicate backporting.

[fanquake]

Added to #26878 for backporting to 24.x.

[fanquake]

Added to #26921 for 23.x.

[fanquake]

Opened #26927 for 22.x.

[maflcko]

While touching headers, the unused #include <config/bitcoin-config.h> can be removed as well.

sgtm.

However, I wonder if we should require for preprocessor stuff that is used in #ifdef or #if to be mentioned in after the include. Otherwise, removing an include can result in a passing but broken build.

For example:

#include <config/bitcoin-config.h> // for FEATURE_FOO