Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix intermittent sync issue in wallet_pruning #27093

Merged
merged 1 commit into from Feb 14, 2023

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Feb 13, 2023

The sync_fun=self.no_op has no motivation or rationale, and seems to be causing issues.

Fix that by removing it.

Actually fixes #27065, see #27066 (comment)

@DrahtBot
Copy link
Contributor

DrahtBot commented Feb 13, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa9ec7b

@fanquake fanquake merged commit af49d86 into bitcoin:master Feb 14, 2023
@maflcko maflcko deleted the 2302-test-sync-int-🥈 branch February 15, 2023 08:26
@bitcoin bitcoin locked and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent issue in wallet_pruning.py
4 participants