ci: fix git dubious permissions error #27423
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
josibake
force-pushed
the
josibake-git-dubious-dir-permissions
branch
from
2c11e94
to
ed4a833
Compare
|
Concept ACK - will test |
|
ACK ed4a833 |
| @@ -57,6 +57,9 @@ if [ -z "$DANGER_RUN_CI_ON_HOST" ]; then | |||
| export CI_EXEC_CMD_PREFIX="docker exec ${CI_CONTAINER_ID}" | |||
| $CI_EXEC_CMD_PREFIX rsync --archive --stats --human-readable /ci_base_install/ "${BASE_ROOT_DIR}" | |||
| $CI_EXEC_CMD_PREFIX rsync --archive --stats --human-readable /ro_base/ "$BASE_ROOT_DIR" | |||
| # Fixes permission issues when there is a container UID/GID mismatch with the owner | |||
| # of the mounted bitcoin src dir. | |||
| $CI_EXEC_CMD_PREFIX git config --global --add safe.directory "*" | |||
There was a problem hiding this comment.
Not sure if it matters, but it could make sense to run this even when CI is run without the docker wrapper. Probably this doesn't affect anyone, but less conditional code seems a win by itself.
There was a problem hiding this comment.
Had to do this here anyway: #27429
ed4a833 ci: fix git dubious permissions error (josibake) Pull request description: fixes bitcoin#27376 (comment) this appears to be caused by a more recent version of git being sensitive to mismatched permissions on directories. we didn't notice this before because we were using two separate user accounts to fix up dir permissions in the container , but the second account was removed in bitcoin#27376 there might be a more elegant way to do this, but this does the trick and seems to be the way others are fixing this issue around the internets. ACKs for top commit: RandyMcMillan: ACK ed4a833 hebasto: re-ACK ed4a833 Tree-SHA512: dad467deca101a24f3ed34b3e26a1db5099a5bd5c3e9c9a22771c59848f7d7e7843c7386348e6fdf86d5a556e4706e5e20005d7a6637193e1c8aef7a5ff7fb19
fixes #27376 (comment)
this appears to be caused by a more recent version of git being sensitive to mismatched permissions on directories. we didn't notice this before because we were using two separate user accounts to fix up dir permissions in the container , but the second account was removed in #27376
there might be a more elegant way to do this, but this does the trick and seems to be the way others are fixing this issue around the internets.