Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: chainparams updates for 25.x #27482

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Apr 18, 2023

Update chainparams pre 25.x branch off.
Co-Author in the commits as a PR (#27223) had previously been opened too-early to do the same.

Note: Remember that some variance is expected in the m_assumed_* sizes.

fanquake and others added 4 commits April 18, 2023 11:02
Co-authored-by: johnny9 <985648+johnny9@users.noreply.github.com>
Co-authored-by: johnny9 <985648+johnny9@users.noreply.github.com>
Co-authored-by: johnny9 <985648+johnny9@users.noreply.github.com>
@fanquake fanquake added this to the 25.0 milestone Apr 18, 2023
@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 18, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK achow101, josibake, gruve-p, dergoegge

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@achow101
Copy link
Member

ACK a2bef80

@josibake
Copy link
Member

ACK a2bef80

verified that I got all the same values on my node for mainnet

@gruve-p
Copy link
Contributor

gruve-p commented Apr 19, 2023

ACK a2bef80

@dergoegge
Copy link
Member

ACK a2bef80 on the new mainnet params

@fanquake fanquake merged commit 3133d93 into bitcoin:master Apr 20, 2023
@fanquake fanquake deleted the assume_valid_pre_25_x branch April 20, 2023 10:24
Copy link
Member

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a2bef80

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK a2bef805c11a4ab391f4ea635bfde7dd2ec9ce81 -- it's what i got on my node too.
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEEWQtykmla/6W2csuy4T/BRc0/QwQFAmRCkgIACgkQ4T/BRc0/
QwQICwv/Y9xMr4N/IfzZo/i49/3TFw6vMi5W4/zu0qluakMU1FCcvrokJ6LbKORA
gZsfLfdXTDdH9q9nXSkHNgQEKUXp15F81qIrv050Q7o02zMTxq9dLixJA30Fzhnz
8g7zCR0ASCzWC0hYHDSTQgYwH0q8cEvwxhfyIEiRTgEjsAFUHn4Ap5q5oQxDWvVR
4flCksNAJzXj7YHcpJbZWvo4Oe3mX4InvhmOF9NlYAmoRVKqmhJzM2CX8s94QvKy
26mE0+ATLFmVTTHubkszytoQnaWHi1ocA4CayO/LJyh8a22K8PHHHd8F0YGJkkd+
Hibmc2+4Lo9yjHf8PMCQGlyBU/ZfJmbd4pzity2mrN09m/AcWm+r0Bzt4AAai3ej
9oIRkPqbNp6G+4nfKlJ1dEaJbR37O95UGdovvuiCC9cMbFWfCxS24xf40EvL4yvP
GqmWB5ILYyGKZNmE+tcJo/OpKQlAaOpTpwTgtyem8B9qIQM02YKcScJA8ryb/dGn
U/8DtahN
=Qp6j
-----END PGP SIGNATURE-----

@bitcoin bitcoin locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants