Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: stop ignoring LIEF imports #27507

Merged
merged 1 commit into from May 29, 2023
Merged

lint: stop ignoring LIEF imports #27507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/lint/04_install.sh
View file
Open in desktop
Expand Up @@ -35,6 +35,7 @@ fi

${CI_RETRY_EXE} pip3 install codespell==2.2.1
${CI_RETRY_EXE} pip3 install flake8==5.0.4
${CI_RETRY_EXE} pip3 install lief==0.13.1
${CI_RETRY_EXE} pip3 install mypy==0.971
${CI_RETRY_EXE} pip3 install pyzmq==24.0.1
${CI_RETRY_EXE} pip3 install vulture==2.6
Expand Down
2 changes: 1 addition & 1 deletion contrib/devtools/security-check.py
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
import sys
from typing import List

import lief #type:ignore
import lief

def check_ELF_RELRO(binary) -> bool:
'''
Expand Down
2 changes: 1 addition & 1 deletion contrib/devtools/symbol-check.py
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@
import sys
from typing import List, Dict

import lief #type:ignore
import lief

# Debian 10 (Buster) EOL: 2024. https://wiki.debian.org/LTS
#
Expand Down
2 changes: 1 addition & 1 deletion contrib/devtools/test-security-check.py
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@
'''
Test script for security-check.py
'''
import lief #type:ignore
import lief
import os
import subprocess
from typing import List
Expand Down
1 change: 1 addition & 0 deletions test/README.md
View file
Open in desktop
Expand Up @@ -331,6 +331,7 @@ Use the `-v` option for verbose output.
| Lint test | Dependency |
|-----------|:----------:|
| [`lint-python.py`](lint/lint-python.py) | [flake8](https://gitlab.com/pycqa/flake8)
| [`lint-python.py`](lint/lint-python.py) | [lief](https://github.com/lief-project/LIEF)
| [`lint-python.py`](lint/lint-python.py) | [mypy](https://github.com/python/mypy)
| [`lint-python.py`](lint/lint-python.py) | [pyzmq](https://github.com/zeromq/pyzmq)
| [`lint-python-dead-code.py`](lint/lint-python-dead-code.py) | [vulture](https://github.com/jendrikseipp/vulture)
Expand Down
2 changes: 1 addition & 1 deletion test/lint/lint-python.py
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@
import subprocess
import sys

DEPS = ['flake8', 'mypy', 'pyzmq']
DEPS = ['flake8', 'lief', 'mypy', 'pyzmq']
MYPY_CACHE_DIR = f"{os.getenv('BASE_ROOT_DIR', '')}/test/.mypy_cache"

# All .py files, except those in src/ (to exclude subtrees there)
Expand Down