http, rest: improving segfault bugfix logic - optimisation #27519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-functional optimisation: moving the logic up in the stack, specifically into the constructor of the HTTPRequest object, this way we catch the invalid uri earlier, removing the exception handling from the rest enpoints as we catch the exception raised from the constructor within the request call back function where we return an http bad request to consumers.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. |
|
Why is this a new PR? You just need to rebase #27253. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As first commit of #27253 was already merged into 25.0 release branch (#27468), this PR represents the second commit of the original PR #27253, where the fix was split in 2 commits for clarity and reviewers benefit(1 with the fix and 1 with an enhancement of it).
Please for reference have a quick look at PRs mentioned above and check the description of this commit for the intention of this PR.