Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: Fixes for file descriptor accounting #27539

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Empact
Copy link
Member

@Empact Empact commented Apr 28, 2023

This rebases and revises #16003 for clarity of review.

Aims to fix #18911.

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 28, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
Concept ACK fjahr, TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #29415 (Broadcast own transactions only via short-lived Tor or I2P connections by vasild)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@Empact Empact force-pushed the 2023-04-minimum-file-descriptor-18911 branch from 856a770 to f9f1460 Compare April 28, 2023 18:38
@Empact Empact force-pushed the 2023-04-minimum-file-descriptor-18911 branch from f9f1460 to bbad166 Compare April 28, 2023 18:39
@glozow glozow added the Docs label May 8, 2023
Copy link
Contributor

@fjahr fjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

I think it would be very helpful to add comments to explain what is going on. See my accidentally duplicate PR for some suggestions: #27730.

#ifdef USE_POLL
int fd_max = nFD;
#else
int fd_max = FD_SETSIZE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an explanation of why it is ok to take FD_SETSIZE completely out of the equation in the commit description.

@TheCharlatan
Copy link
Contributor

Concept ACK

First three commits look good, but the last one needs more descriptions and comments as mentioned by fjahr.

@DrahtBot
Copy link
Contributor

DrahtBot commented Feb 5, 2024

🤔 There hasn't been much activity lately and the CI seems to be failing.

If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn't been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.

Empact and others added 4 commits March 4, 2024 15:38
Co-authored-by: tryphe <tryphe@noreply.github.com>
And fix the amount of descriptors requested

Co-authored-by: tryphe <tryphe@noreply.github.com>
@Empact Empact force-pushed the 2023-04-minimum-file-descriptor-18911 branch from bbad166 to 44872b3 Compare March 4, 2024 18:38
@DrahtBot DrahtBot removed the CI failed label Mar 4, 2024
@TheCharlatan
Copy link
Contributor

This was rebased fairly recently, but you have not addressed this open comment #27539 (comment) . Are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve minimum file descriptor accounting and documentation
5 participants