guix: document when certain patches can be dropped #27668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
hebasto
reviewed
May 16, 2023
contrib/guix/patches/glibc-2.27-riscv64-Use-__has_include-to-include-asm-syscalls.h.patch
Show resolved
Hide resolved
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 17, 2023
a09269a guix: document when certain guix patches can be dropped (fanquake) Pull request description: Additional notes for when patches can be dropped. ACKs for top commit: hebasto: ACK a09269a, I have reviewed the changes and they look OK. jarolrod: ACK a09269a Tree-SHA512: c1876b9a4e3cf73645d25c9077cef19a9b6b7fe2eda5dc9d82fd3ca3f9105453406c1b197e6635035b6ce19c9f255c070bebed5563f68913033d04627202155a
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
May 31, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
May 31, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 3, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 6, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 7, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 8, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 10, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 11, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 11, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 11, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 19, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 20, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 20, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 20, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 20, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 20, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 20, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 29, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 29, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 30, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 30, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 3, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 4, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 9, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 10, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 28, 2023
UdjinM6
pushed a commit
to kwvg/dash
that referenced
this pull request
Jul 30, 2023
PastaPastaPasta
pushed a commit
to kwvg/dash
that referenced
this pull request
Aug 1, 2023
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 31, 2024
…dant glibc patches Summary: > guix: document when certain guix patches can be dropped Note that we don't support powerpc, and the glibc-2.28-fcommon patch mentions that it specifically fixes an issue for this platform, but the patch is applied by Core to all builds, so it is best to keep it. > guix: remove redundant glibc patches > > These should only be relevant for a glibc that is built as part of a > Guix system, and should not be required for a glibc that is just being > built to compile our binaries against. A x86_64 linux bitcoind produced > with Guix using master vs this change has no difference. i.e: This is a backport of [[bitcoin/bitcoin#27668 | core#27668]] and [[bitcoin/bitcoin#27670 | core#27670]] Depends on D15330 Test Plan: `contrib/guix/guix-build` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D15331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional notes for when patches can be dropped.