wallet: clarify replace fields in help output #27782
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
I suppose that changing them in |
torkelrogstad
force-pushed
the
2023-05-30-replace-docs
branch
from
02eb966
to
d6f77ae
Compare
torkelrogstad
changed the title
|
Thanks for pointing that out @brunoerg. Updated the commit message and PR title. |
|
otoh, it would be nice to populate these when we detect a replaced receive tx... |
| {RPCResult::Type::STR_HEX, "replaced_by_txid", /*optional=*/true, "The txid if this tx was replaced."}, | ||
| {RPCResult::Type::STR_HEX, "replaces_txid", /*optional=*/true, "The txid if the tx replaces one."}, | ||
| {RPCResult::Type::STR_HEX, "replaced_by_txid", /*optional=*/true, "Only if 'category' is 'send'. The txid if this tx was replaced."}, | ||
| {RPCResult::Type::STR_HEX, "replaces_txid", /*optional=*/true, "Only if 'category' is 'send'. The txid if the tx replaces one."}, |
There was a problem hiding this comment.
| {RPCResult::Type::STR_HEX, "replaces_txid", /*optional=*/true, "Only if 'category' is 'send'. The txid if the tx replaces one."}, | |
| {RPCResult::Type::STR_HEX, "replaces_txid", /*optional=*/true, "Only if 'category' is 'send'. The txid if this tx replaces another."}, |
|
Are you still working on it? |
|
Closing as up for grabs for now, due to lack of reply |
Closes #27781.