Renamed UniValue::__pushKV to UniValue::pushKVEnd.

[Brotcrunsher]

Any identifier starting with 2 _ is reserved for the compiler and thus must not be used.

See: https://stackoverflow.com/a/228797/7130273

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	MarcoFalke

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #27788 (rpc: Be able to access RPC parameters by name by achow101)
• #27742 ([NO MERGE] BIP331 Ancestor Package Relay by glozow)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[hebasto]

See https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#scripted-diffs for changes like this.

[maflcko]

lgtm ACK acad989

[hebasto]

Does it make sense to force such changes with the Clang's -Wreserved-identifier diagnostic flag?

[fanquake]

@Brotcrunsher are you going to rebase this?

[maflcko]

Does it make sense to force such changes with the Clang's -Wreserved-identifier diagnostic flag?

I get a warning about _EraseTx and this:

diff --git a/src/support/allocators/secure.h b/src/support/allocators/secure.h
index a0918bf463..b2076bea07 100644
--- a/src/support/allocators/secure.h
+++ b/src/support/allocators/secure.h
@@ -32,9 +32,9 @@ struct secure_allocator : public std::allocator<T> {
     {
     }
     ~secure_allocator() noexcept {}
-    template <typename _Other>
+    template <typename Other>
     struct rebind {
-        typedef secure_allocator<_Other> other;
+        typedef secure_allocator<Other> other;
     };
 
     T* allocate(std::size_t n, const void* hint = nullptr)
diff --git a/src/support/allocators/zeroafterfree.h b/src/support/allocators/zeroafterfree.h
index 795eea3bc0..2dc644c242 100644
--- a/src/support/allocators/zeroafterfree.h
+++ b/src/support/allocators/zeroafterfree.h
@@ -27,9 +27,9 @@ struct zero_after_free_allocator : public std::allocator<T> {
     {
     }
     ~zero_after_free_allocator() noexcept {}
-    template <typename _Other>
+    template <typename Other>
     struct rebind {
-        typedef zero_after_free_allocator<_Other> other;
+        typedef zero_after_free_allocator<Other> other;
     };
 
     void deallocate(T* p, std::size_t n)

[hebasto]

Does it make sense to force such changes with the Clang's -Wreserved-identifier diagnostic flag?

I get a warning about _EraseTx and this:

I got the same. Could be added to this PR, no?

[maflcko]

Please follow the commit subject max len, according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#committing-patches

[Brotcrunsher]

Please follow the commit subject max len

Thanks for the feedback, done! One detail question regarding the max length (not important for this Commit, just want to learn for the future). Are CI triggers like "scripted-diff: " considered as part of the subject line and thus part of the 80 chars limitation?

[maflcko]

lgtm ACK bdea2bb

[fanquake]

Does it make sense to force such changes with the Clang's -Wreserved-identifier diagnostic flag?

Doing so is going to require further suppressing, or changes in upstream code. i.e:

./minisketch/include/minisketch.h:2:9: warning: macro name is a reserved identifier [-Wreserved-macro-identifier]
#define _MINISKETCH_H_ 1
        ^
1 warning generated.
./crypto/ctaes/ctaes.h:8:9: warning: macro name is a reserved identifier [-Wreserved-macro-identifier]
#define _CTAES_H_ 1
        ^
1 warning generated.
./leveldb/port/thread_annotations.h:16:9: warning: macro name is a reserved identifier [-Wreserved-macro-identifier]
#define THREAD_ANNOTATION_ATTRIBUTE__(x) __attribute__((x))
        ^
1 warning generated.
minisketch/src/util.h:16:11: warning: macro name is a reserved identifier [-Wreserved-macro-identifier]
#  define __GNUC_PREREQ(_maj,_min) \
          ^
3 warnings generated.