New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: clarify full Xcode download is not needed #27835
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. |
LGTM! |
Not sure if this is needed? Anyone to copy-paste the command shouldn't run into issues and if you do random other stuff, you are on your own anyway? |
doc/build-osx.md
Outdated
@@ -17,6 +17,7 @@ macOS comes with a built-in Terminal located in: | |||
|
|||
The Xcode Command Line Tools are a collection of build tools for macOS. | |||
These tools must be installed in order to build Bitcoin Core from source. | |||
You do not need to install all of Xcode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems weird to say "you don't need to install" and the next line "To install, run...". If we want to advertise something, I prefer something like: "Recent MacOS versions may contain Xcode by default"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macOS does not ship with all of Xcode, but they do ship with the xcode-select
command.
Some background, it should indeed not be necessary to install Xcode: https://www.freecodecamp.org/news/install-xcode-command-line-tools/ I improved the prose a bit. |
39052a0
to
29be2d2
Compare
It hasn't been required for at least 7 years, that's why we removed the instructions to install in: 2692e1b. |
Agree with the above. Not sure where the confusion is coming from, and, as mentioned, this hasn't be required for at least 7 years, if not longer than that. Anyone who is following this guide, and just copy-pasting commands, shouldn't be accidently going to the macOS App Store and downloading the ~8GB Xcode app bundle. |
Some people keep thinking that you need to download the full 4GB of Xcode before running
xcode-select
. Howeverxcode-select
is already present on any freshly installed macOS.