ci: Switch to amd64 container in "ARM" task
#27886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tee `arm_container` does not support 32-bit mode anymore. See: bitcoin#27879
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
review ACK 016fe6d if CI is green A smaller diff would be to just unset the Longer term we can also think about whether we want to test aarch64 or arm32 in this CI task, but this can be done later. |
|
Looks like this was, as expected, wrapped in qemu and the task passed: https://cirrus-ci.com/task/5196388229709824?logs=ci#L3590 |
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jun 14, 2023
Tee `arm_container` does not support 32-bit mode anymore. See: bitcoin#27879 Github-Pull: bitcoin#27886 Rebased-From: 016fe6d
Merged
|
Backported to 25.x in #27887. |
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jun 15, 2023
Tee `arm_container` does not support 32-bit mode anymore. See: bitcoin#27879 Github-Pull: bitcoin#27886 Rebased-From: 016fe6d
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 15, 2023
016fe6d ci: Switch to `amd64` container in "ARM" task (Hennadii Stepanov) Pull request description: The `arm_container` does not support 32-bit mode anymore. Fixes bitcoin#27879. Also, the `arm_container` could be used for testing `aarch64` binaries, which are the part of our releases. Leaving that for another PR. ACKs for top commit: MarcoFalke: review ACK 016fe6d if CI is green Tree-SHA512: cdcc034938f4c101e211fceca0dcd7f50258f1085b74d6abe50bb0f45f1b92b99e2763436271583fdbad194cb9ed7e266d5597274555110ceaa7d762fe5a49d9
fanquake
added a commit
that referenced
this pull request
Jun 16, 2023
6233049 ci: Switch to `amd64` container in "ARM" task (Hennadii Stepanov) d845a3e test: add coverage for `/deploymentinfo` passing a blockhash (brunoerg) 72ead86 rest: bugfix, fix crash error when calling `/deploymentinfo` (brunoerg) 6f7a0ae ci: Use podman stop over podman kill (MarcoFalke) de56daa ci: Use podman for persistent workers (MarcoFalke) 71f626e ci: Prune dangling images on RESTART_CI_DOCKER_BEFORE_RUN (MarcoFalke) Pull request description: Currently backports: * #27777 * #27844 * #27853 * #27886 Effectively also backports: #27562. ACKs for top commit: stickies-v: ACK 6233049 Tree-SHA512: d0f3d5c4cd0cf9792f3270078b49ad6661e28e7a883f91e5981e8cfe95d01c6e415762ee2e3a5fea17d198299989a8b5412961c2cc788cef975b2ee45d84550c
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Oct 2, 2023
Tee `arm_container` does not support 32-bit mode anymore. See: bitcoin#27879 Github-Pull: bitcoin#27886 Rebased-From: 016fe6d
fanquake
added a commit
that referenced
this pull request
Oct 6, 2023
9077f21 depends: fix unusable memory_resource in macos qt build (fanquake) dccacf0 build, macos: Fix `qt` package build with new Xcode 15 linker (Hennadii Stepanov) 4359649 ci: Switch to `amd64` container in "ARM" task (Hennadii Stepanov) 805f98b ci: Nuke Android APK task, Use credits for tsan (MarcoFalke) cb5512d test: ensure old fee_estimate.dat not read on restart and flushed (ismaelsadeeq) 01f8ee4 tx fees, policy: read stale fee estimates with a regtest-only option (ismaelsadeeq) 1c98029 tx fees, policy: do not read estimates of old fee_estimates.dat (ismaelsadeeq) 77979e0 tx fees, policy: periodically flush fee estimates to fee_estimates.dat (ismaelsadeeq) 67b6d99 Do not use std::vector = {} to release memory (Pieter Wuille) defdc15 ci: Use podman stop over podman kill (MarcoFalke) 7f1357d ci: Use podman for persistent workers (MarcoFalke) 0db69a3 ci: Prune dangling images on RESTART_CI_DOCKER_BEFORE_RUN (MarcoFalke) Pull request description: Backports to the 24.x branch. Currently: * #27622 * #27777 * #27834 * #27844 * #27886 * #28452 * #28543 * #28571 ACKs for top commit: stickies-v: ACK 9077f21 Tree-SHA512: abaafc9a048b67b494993134fd332457ea52695ec007b963c283f962ec40c3b6b3a7e98407481be55d3271a595088a0281cc84b79dad4f24d260381ea0153076
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
arm_containerdoes not support 32-bit mode anymore.Fixes #27879.
Also, the
arm_containercould be used for testingaarch64binaries, which are the part of our releases. Leaving that for another PR.