Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: test: update TestShell instructions #27906

Merged

Conversation

ismaelsadeeq
Copy link
Member

Fixes #27904

From #27904 and IRC.
Update Testshell instructions

E.g TestShell.setup() throws

AttributeError: type object 'TestShell' has no attribute 'setup'

Parentheses are missing, it should be TestShell().setup()

add missing parentheses `TestShell.method` should be `TestShell().method`.
@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 16, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK Sjors, brunoerg, hernanmarino

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Docs label Jun 16, 2023
@Sjors
Copy link
Member

Sjors commented Jun 17, 2023

Thanks!

utACK 14405e8

cc @theStack

Copy link
Contributor

@brunoerg brunoerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crACK 14405e8

Copy link
Contributor

@hernanmarino hernanmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 14405e8

@DrahtBot DrahtBot requested review from hernanmarino and removed request for hernanmarino June 18, 2023 03:42
@fanquake fanquake merged commit 7f0b79e into bitcoin:master Jun 18, 2023
15 checks passed
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestShell doesn't work
6 participants