Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add implicit-signed-integer-truncation:*/include/c++/ suppression #27940

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Jun 23, 2023

Needed for aarch64. Steps to test on aarch64:

lscpu | grep Arch
FILE_ENV="./ci/test/00_setup_env_native_fuzz.sh" ./ci/test_run_all.sh

@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 23, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label Jun 23, 2023
@maflcko
Copy link
Member Author

maflcko commented Jun 23, 2023

Result on this pull: ✔️
Result on current master:

INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed: 3780003785
INFO: Loaded 1 modules   (524068 inline 8-bit counters): 524068 [0xaaaac33c0c60, 0xaaaac3440b84), 
INFO: Loaded 1 PC tables (524068 PCs): 524068 [0xaaaac3440b88,0xaaaac3c3fdc8), 
INFO:     1035 files found in /root/b-c-ci/ci/scratch/qa-assets/fuzz_seed_corpus/addition_overflow
INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 1048576 bytes
/usr/bin/../lib/gcc/aarch64-linux-gnu/12/../../../../include/c++/12/limits:461:44: runtime error: implicit conversion from type 'int' of value -1 (32-bit, signed) to type 'char' changed the value to 255 (8-bit, unsigned)
    #0 0xaaaac029e9f0  (/root/b-c-ci/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x196e9f0) (BuildId: 1220a8087bcbf3445e747964b3c67d5afce5c0a8)
    #1 0xaaaac0822514  (/root/b-c-ci/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x1ef2514) (BuildId: 1220a8087bcbf3445e747964b3c67d5afce5c0a8)
    #2 0xaaaac013f9fc  (/root/b-c-ci/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x180f9fc) (BuildId: 1220a8087bcbf3445e747964b3c67d5afce5c0a8)
    #3 0xaaaac0140d4c  (/root/b-c-ci/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x1810d4c) (BuildId: 1220a8087bcbf3445e747964b3c67d5afce5c0a8)
    #4 0xaaaac0141374  (/root/b-c-ci/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x1811374) (BuildId: 1220a8087bcbf3445e747964b3c67d5afce5c0a8)
    #5 0xaaaac01303b4  (/root/b-c-ci/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x18003b4) (BuildId: 1220a8087bcbf3445e747964b3c67d5afce5c0a8)
    #6 0xaaaac01577a0  (/root/b-c-ci/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x18277a0) (BuildId: 1220a8087bcbf3445e747964b3c67d5afce5c0a8)
    #7 0xffffacbb6dbc  (/lib/aarch64-linux-gnu/libc.so.6+0x26dbc) (BuildId: 9efe43e32e614cad22a180ef036eea6154eafdc2)
    #8 0xffffacbb6e94  (/lib/aarch64-linux-gnu/libc.so.6+0x26e94) (BuildId: 9efe43e32e614cad22a180ef036eea6154eafdc2)
    #9 0xaaaac012676c  (/root/b-c-ci/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x17f676c) (BuildId: 1220a8087bcbf3445e747964b3c67d5afce5c0a8)

SUMMARY: UndefinedBehaviorSanitizer: implicit-signed-integer-truncation /usr/bin/../lib/gcc/aarch64-linux-gnu/12/../../../../include/c++/12/limits:461:44 in 
MS: 0 ; base unit: 0000000000000000000000000000000000000000


artifact_prefix='./'; Test unit written to ./crash-da39a3ee5e6b4b0d3255bfef95601890afd80709
Base64: 

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fae55f9 - reproduced the failure:

Run addition_overflow with args ['/home/fedora/ci_scratch/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz', '-runs=1', PosixPath('/home/fedora/ci_scratch/ci/scratch/qa-assets/fuzz_seed_corpus/addition_overflow')]INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed: 3855426920
INFO: Loaded 1 modules   (524434 inline 8-bit counters): 524434 [0xaaaabd411960, 0xaaaabd4919f2), 
INFO: Loaded 1 PC tables (524434 PCs): 524434 [0xaaaabd4919f8,0xaaaabdc92318), 
INFO:     1035 files found in /home/fedora/ci_scratch/ci/scratch/qa-assets/fuzz_seed_corpus/addition_overflow
INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 1048576 bytes
/usr/bin/../lib/gcc/aarch64-linux-gnu/12/../../../../include/c++/12/limits:461:44: runtime error: implicit conversion from type 'int' of value -1 (32-bit, signed) to type 'char' changed the value to 255 (8-bit, unsigned)
    #0 0xaaaaba2ceb3c  (/home/fedora/ci_scratch/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x196eb3c) (BuildId: f5d27a6d5a45afb06eb7e90ec7f599098db47820)
    #1 0xaaaaba85792c  (/home/fedora/ci_scratch/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x1ef792c) (BuildId: f5d27a6d5a45afb06eb7e90ec7f599098db47820)
    #2 0xaaaaba16fa3c  (/home/fedora/ci_scratch/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x180fa3c) (BuildId: f5d27a6d5a45afb06eb7e90ec7f599098db47820)
    #3 0xaaaaba170d8c  (/home/fedora/ci_scratch/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x1810d8c) (BuildId: f5d27a6d5a45afb06eb7e90ec7f599098db47820)
    #4 0xaaaaba1713b4  (/home/fedora/ci_scratch/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x18113b4) (BuildId: f5d27a6d5a45afb06eb7e90ec7f599098db47820)
    #5 0xaaaaba1603f4  (/home/fedora/ci_scratch/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x18003f4) (BuildId: f5d27a6d5a45afb06eb7e90ec7f599098db47820)
    #6 0xaaaaba1877e0  (/home/fedora/ci_scratch/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x18277e0) (BuildId: f5d27a6d5a45afb06eb7e90ec7f599098db47820)
    #7 0xffff9ea86dbc  (/lib/aarch64-linux-gnu/libc.so.6+0x26dbc) (BuildId: 9efe43e32e614cad22a180ef036eea6154eafdc2)
    #8 0xffff9ea86e94  (/lib/aarch64-linux-gnu/libc.so.6+0x26e94) (BuildId: 9efe43e32e614cad22a180ef036eea6154eafdc2)
    #9 0xaaaaba1567ac  (/home/fedora/ci_scratch/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x17f67ac) (BuildId: f5d27a6d5a45afb06eb7e90ec7f599098db47820)

SUMMARY: UndefinedBehaviorSanitizer: implicit-signed-integer-truncation /usr/bin/../lib/gcc/aarch64-linux-gnu/12/../../../../include/c++/12/limits:461:44 in 
MS: 0 ; base unit: 0000000000000000000000000000000000000000


artifact_prefix='./'; Test unit written to ./crash-da39a3ee5e6b4b0d3255bfef95601890afd80709

verified the fix.

@fanquake fanquake merged commit 7ee4121 into bitcoin:master Jun 27, 2023
15 checks passed
@maflcko maflcko deleted the 2306-fuzz-supp-aarch64- branch June 27, 2023 15:01
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 30, 2023
…nclude/c++/ suppression

fae55f9 test: Add implicit-signed-integer-truncation:*/include/c++/ suppression (MarcoFalke)

Pull request description:

  Needed for aarch64. Steps to test on aarch64:

  ```
  lscpu | grep Arch
  FILE_ENV="./ci/test/00_setup_env_native_fuzz.sh" ./ci/test_run_all.sh
  ```

ACKs for top commit:
  fanquake:
    ACK fae55f9  - reproduced the failure:

Tree-SHA512: b5058873118d285cc5d678a572cf4b890f8d68a24e1ac0987490f1b4123469a2b4456b08474f372e6aa49bb0d69e16f2c8277208b1cde3222a317f000beb5056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants