Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fuzz: add target for ScriptPubKeyMan (legacy) #28153

Closed
wants to merge 1 commit into from
Closed

fuzz: add target for ScriptPubKeyMan (legacy) #28153

wants to merge 1 commit into from

Conversation

brunoerg
Copy link
Contributor

This PR adds target for {Legacy}ScriptPubKeyMan. I'm working on a descriptor one and will do it in a separate file. I tried to focus here on functions that we use directly and we may have in some unit tests.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jul 25, 2023 •
edited

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
Concept ACK Ayush170-Future

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #28236 (fuzz: wallet, add target for Spend by Ayush170-Future)
  • #26606 (wallet: Implement independent BDB parser by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot added the Tests label Jul 25, 2023
@brunoerg brunoerg marked this pull request as ready for review July 25, 2023 20:49
This was referenced Jul 26, 2023
Open
Draft
@brunoerg brunoerg marked this pull request as draft July 26, 2023 10:01
@brunoerg brunoerg force-pushed the 2023-07-fuzz-scriptpubkey-legacy branch from e951d31 to c2e197a Compare July 26, 2023 14:22
@brunoerg brunoerg marked this pull request as ready for review July 26, 2023 16:23
@brunoerg
Copy link
Contributor Author

CI failure seems unrelated.

@brunoerg brunoerg force-pushed the 2023-07-fuzz-scriptpubkey-legacy branch from c2e197a to dbe54b1 Compare July 26, 2023 16:26
@brunoerg
Copy link
Contributor Author

Pushed to re-run CI.

Ayush170-Future
Ayush170-Future approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@Ayush170-Future Ayush170-Future left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

I support the idea of having separate files for Legacy and Descriptor because I think the Wallet implementation would differ. Overall, the code looks great to me.

@brunoerg brunoerg force-pushed the 2023-07-fuzz-scriptpubkey-legacy branch 3 times, most recently from 09aa5cf to f67d8ec Compare July 27, 2023 20:36
maflcko
maflcko approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/wallet/test/fuzz/scriptpubkeyman.cpp Outdated Show resolved Hide resolved
@brunoerg brunoerg force-pushed the 2023-07-fuzz-scriptpubkey-legacy branch from f67d8ec to eb4d8b3 Compare July 28, 2023 14:55
@fanquake fanquake requested a review from achow101 August 1, 2023 12:43
@DrahtBot DrahtBot mentioned this pull request Aug 8, 2023
Open
@achow101
Copy link
Member

Closing as there is little support for working on fixing non-critical issues in legacy wallets.

@achow101 achow101 closed this Sep 20, 2023
@maflcko
Copy link
Member

maflcko commented Sep 20, 2023

Would be nice to have a descriptor wallet target? Alternatively, I think your plan was to speed up wallet_notifications IIRC?

@brunoerg
Copy link
Contributor Author

Would be nice to have a descriptor wallet target? Alternatively, I think your plan was to speed up wallet_notifications IIRC?

Yes, I'm working on speeding up wallet_notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maflcko maflcko maflcko approved these changes

@Ayush170-Future Ayush170-Future Ayush170-Future approved these changes

@achow101 achow101 Awaiting requested review from achow101

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brunoerg @DrahtBot @achow101 @maflcko @Ayush170-Future