Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set DEFAULT_PERMIT_BAREMULTISIG to false #28217

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −1
Open

set DEFAULT_PERMIT_BAREMULTISIG to false #28217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bc554e
Change `DEFAULT_PERMIT_BAREMULTISIG` to false
Retropex Jan 17, 2024
8672721
Release note for changing `-permitbaremultisig` config default to false
Retropex Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/release-notes-28217.md
View file
Open in desktop
@@ -0,0 +1,4 @@
P2P and network changes
-----------------------

- Changing the default setting of -permitbaremultisig to false. Non-P2SH multisig transactions will no longer be relayed by default. (#28217)
Copy link
Contributor

@jonatack jonatack Feb 2, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if you need to repush, so as not to invalidate the current review ACKs, in commit 8672721 perhaps consider the following diff.

-P2P and network changes
------------------------
+Updated settings
+----------------
 
-- Changing the default setting of -permitbaremultisig to false. Non-P2SH multisig transactions will no longer be relayed by default. (#28217)
\ No newline at end of file
+- The default value of the `-permitbaremultisig` configuration option is changed
+  from true to false.  Non-P2SH multisig transactions will be considered
+  non-standard by the node and no longer relayed by default. (#28217)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's noted.

2 changes: 1 addition & 1 deletion src/policy/policy.h
View file
Open in desktop
Expand Up @@ -36,7 +36,7 @@ static constexpr unsigned int DEFAULT_INCREMENTAL_RELAY_FEE{1000};
/** Default for -bytespersigop */
static constexpr unsigned int DEFAULT_BYTES_PER_SIGOP{20};
/** Default for -permitbaremultisig */
static constexpr bool DEFAULT_PERMIT_BAREMULTISIG{true};
static constexpr bool DEFAULT_PERMIT_BAREMULTISIG{false};
Retropex marked this conversation as resolved.
Show resolved Hide resolved
/** The maximum number of witness stack items in a standard P2WSH script */
static constexpr unsigned int MAX_STANDARD_P2WSH_STACK_ITEMS{100};
/** The maximum size in bytes of each witness stack item in a standard P2WSH script */
Expand Down